[Bug 657518] Review Request: perl-Net-Amazon-EC2-Metadata - Retrieves data from EC2 Metadata service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657518

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2011-01-04 08:33:36 EST ---
Source tar ball is original. Ok.
Summary verified from lib/Net/Amazon/EC2/Metadata.pm. Ok.
License verified from lib/Net/Amazon/EC2/Metadata.pm. Ok.
Description verified from lib/Net/Amazon/EC2/Metadata.pm. Ok.
TODO: Missing full stop in Description after first sentence.

Is the bug report https://bugzilla.gooddata.com/show_bug.cgi?id=4395 referred
from net-amazon-ec2-metadata.diff patch public? The server requires
authentication.

FIX: BuildRequire perl(Test::Pod) >= 1.14 (t/pod.t:4)
FIX: BuildRequire perl(Test::Pod::Coverage) > 1.04 (t/pod-coverage.t:4)

All tests pass. Ok.

$ rpmlint perl-Net-Amazon-EC2-Metadata.spec
../SRPMS/perl-Net-Amazon-EC2-Metadata-0.10-3.fc14.src.rpm
../RPMS/noarch/perl-Net-Amazon-EC2-Metadata-0.10-3.fc14.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

$ rpm -pqlv ../RPMS/noarch/perl-Net-Amazon-EC2-Metadata-0.10-3.fc14.noarch.rpm 
-rwxr-xr-x    1 root    root                     2412 led  4 14:05
/usr/bin/ec2meta
drwxr-xr-x    2 root    root                        0 led  4 14:05
/usr/share/doc/perl-Net-Amazon-EC2-Metadata-0.10
-rw-r--r--    1 root    root                      103 led 21  2008
/usr/share/doc/perl-Net-Amazon-EC2-Metadata-0.10/Changes
-rw-r--r--    1 root    root                      945 led 22  2008
/usr/share/doc/perl-Net-Amazon-EC2-Metadata-0.10/README
-rw-r--r--    1 root    root                     2357 led  4 14:05
/usr/share/man/man1/ec2meta.1.gz
-rw-r--r--    1 root    root                     3032 led  4 14:05
/usr/share/man/man3/Net::Amazon::EC2::Metadata.3pm.gz
drwxr-xr-x    2 root    root                        0 led  4 14:05
/usr/share/perl5/Net
drwxr-xr-x    2 root    root                        0 led  4 14:05
/usr/share/perl5/Net/Amazon
drwxr-xr-x    2 root    root                        0 led  4 14:05
/usr/share/perl5/Net/Amazon/EC2
-rw-r--r--    1 root    root                     7567 led  4 14:05
/usr/share/perl5/Net/Amazon/EC2/Metadata.pm
File permissions and layout is Ok.

$ rpm -pq --requires
../RPMS/noarch/perl-Net-Amazon-EC2-Metadata-0.10-3.fc14.noarch.rpm | sort |
uniq -c
      1 perl(Carp)  
      1 perl(Data::Dumper)  
      1 perl(Getopt::Long)  
      2 perl(LWP::Simple)  
      1 perl(:MODULE_COMPAT_5.12.2)  
      1 perl(Net::Amazon::EC2::Metadata)  
      1 perl(Pod::Usage)  
      1 perl(strict)  
      1 perl(vars)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 /usr/bin/perl  
FIX: Do not Require perl(LWP::Simple) explicitly, it's discovered by rpmbuild.

$ rpm -pq --provides
../RPMS/noarch/perl-Net-Amazon-EC2-Metadata-0.10-3.fc14.noarch.rpm | sort |
uniq -c
      1 perl(Net::Amazon::EC2::Metadata)  
      1 perl-Net-Amazon-EC2-Metadata = 0.10-3.fc14
Binary Provides Ok.

$ resolvedeps-f15
../RPMS/noarch/perl-Net-Amazon-EC2-Metadata-0.10-3.fc14.noarch.rpm 
Binary dependencies Ok.

Package build in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2700338). Ok.

Tests from koji:
t/pod-coverage.t .. skipped: Test::Pod::Coverage 1.04 required for testing POD
coverage
t/pod.t ........... skipped: Test::Pod 1.14 required for testing POD
FIX: Add the BuildRequires as written above.

Otherwise the package is in line with Fedora and perl packaging guide lines.


Please correct all FIX prefixed issues and publish new spec file. Consider
fixing TODO prefixed issues too.
Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.