[Bug 666633] Review Request: liblastfmlib - library providing implementation of LastFm Submission Protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=666633

Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
               Flag|                            |fedora-review?

--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de> 2011-01-04 14:02:14 EST ---
Hallo,

here some pre-review complaints:

1.) I dont't like the package name liblastfmlib. It may be better to choich
lastfmlib as an package name.

2.) you hve the buildRoot tag twice in your package. Current RPM releases
doesn't need an BuildRoot tag. They are required only for EPEL-branches.

3.) the devel subpackage need a Requires to the main package in the form:
Requires: %{name} = %{version}-%{release}

4.) Instead of '-n liblastfmlib-devel' you shoud prefer to write only 'devel'
ot refer to the subpackage in the tags.

5.) It may be nice to insert a blank line between the %package and the
%description stanza.

6.) Please us %{_includedir} instead of /usr/include

7.) Please use %{?_smp_mflags} to initiate a parallel build.

8:) Don't use the %makeinstall macro

9.) You don't need to specified the name of the main package in the %file
stanza

10.) Please remove the *.la file from the devel package

11.) The license tag have to been GPLv2+. Please examinate the copyrith notes
on the top of the sources files. This notes say, that you ca use the second
version of the GPL or any later version, so you have to use GPLv2+ for the
license tag.

12.) Upstream tar ball contains a verbatin copy of the license text which was
not included in the package on the %doc stanza.

13 Pakcage has not %doc stanza with files like README which are provided by
upstream authow

14.) You should use %{_includedir}/lastfm/ in the %files stanza to make sure,
that this directory is onwed by the package. All Files and directories belong
this directory will be included to the package, so no additional specification
is required

15.) the specification of gcc-c++ as a BuildRequires is not required

Sorry for the long list of complaints, but if you are able to create a proper
package, I may will sponsor you.

Best Regards:

Jochen Schmitt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.