[Bug 666954] Review Request: cherrytree - Hierarchical note taking application

bugzilla at redhat.com bugzilla at redhat.com
Tue Jan 4 22:03:16 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=666954

--- Comment #8 from Thomas Spura <tomspur at fedoraproject.org> 2011-01-04 17:03:15 EST ---
(In reply to comment #1)
> Thomas, this is python. ;)

Hehe, nice ;-)

(In reply to comment #7)
> * I hope you can convince upstream to rid of gtk requirement from setup.py. It
> should be an easy job.

Not that easy...
gtk is not required in setup.py. They import the cons module to get the version
from there. So it would be best, if they would introduce a new *.py file for
the gtk variables and import it from there.
(patch below)

But I would suggest to not install into %{python_sitelib}, because upstream
(and so othere distributions don't do that too, but your choice ;-)

It's starting up, but it would be better to ask upstream, if the patch is ok...

SPEC: http://tomspur.fedorapeople.org/review/cherrytree.spec
PATCH:http://tomspur.fedorapeople.org/review/cherrytree-gtk-dep.patch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list