[Bug 665331] Review Request: perl-Imager - Perl extension for Generating 24 bit Images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665331

--- Comment #2 from Ralf Corsepius <rc040203 at freenet.de> 2011-01-05 05:46:55 EST ---
(In reply to comment #1)
> MUST Items:
> [+] MUST: rpmlint must be run on every package.
> $ rpmlint ./RPMS/i686/perl-Imager-0.79-1.fc14.i686.rpm
> ./RPMS/i686/perl-Imager-debuginfo-0.79-1.fc14.i686.rpm SPECS/perl-Imager.spec
> SRPMS/perl-Imager-0.79-1.fc15.src.rpm 
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imext.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imrender.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imperl.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/rendert.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/immacros.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/ext.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imextdef.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/dynaload.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/stackmach.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imextpltypes.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/iolayer.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imexttypes.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/ppport.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/draw.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imextpl.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imerror.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imio.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imconfig.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/iolayert.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imager.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/log.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/feat.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imageri.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/regmach.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/plug.h
> perl-Imager.i686: W: devel-file-in-non-devel-package
> /usr/lib/perl5/Imager/include/imdatatypes.h
The warning are all bogus (== rpmlint is wrong on these)-.


> [-] MUST: The sources used to build the package must match the upstream source,
> as provided in the spec URL.
> Upstream: 
> $ md5sum Imager-0.79.tar.gz 
> ec73e34a0f6482a5a2d0178192f4837f  Imager-0.79.tar.gz
> 
> SRPM tarball:
> $ md5sum perl-Imager-0.79-1.fc15.src/Imager-0.79.tar.gz 
> eec0b53661ccce1fdb3b521037128a72 
> perl-Imager-0.79-1.fc15.src/Imager-0.79.tar.gz
> 
> [+] MUST: The package must successfully compile and build into binary rpms on
> at least one supported architecture.
> [=] MUST: All build dependencies must be listed in BuildRequires
> It is recommended to buildrequire core modules explicitly:
> 
> perl(Config)  
> perl(constant)  
> perl(Exporter)  
> perl(File::Basename)  
> perl(File::Spec)
> perl(IO::File)  
> perl(strict)  
> perl(Test::Builder)  
> perl(vars) 
You are over-interpreting the guidelines.

It's common practice in perl package to only require explicitly required
modules (typically those from META.yml) and those required to run the tests.

Explicit requiring perl-core modules NOT required and doesn't make sense.

> Extra comments:
> [-] URL should be http://imager.perl.org/
This is a CPAN package. The URL needs to point to CPAN.

> [=] Consider including Changes.old
I disagree. Changes.old only contains many years old infomation which hardly is
relevant to users.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.