[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657403

--- Comment #7 from Marc-Andre Lureau <marcandre.lureau at gmail.com> 2011-01-05 07:18:15 EST ---
(In reply to comment #6)
> Full review done:
> 
> 
> Some minor nitpicks / should fix items:
> - The Group tag for the main package should be: System Environment/Libraries

done

> - "Requires:      %{name} = %{version}" should be dropped

done

> - The %description for the main package talks about a gtk client and libraries,
>   but the gtk client is part of the tools package

done: "Client libraries for SPICE desktop servers."

> - Likewise the %description for tools does not mention the gtk client

done: "Simple clients for interacting with SPICE servers."

> - The "Requires: %{name} = %{version}" does not specify the release in the
>   package, when subpackages depend on other packages in the same SRPM the
>   requires should specify the full NEVR (name epoch version release) like the
>   Requires in the devel sub package

fixed, for spice-gtk-python

> - The prefered form for the defattr is:
> %defattr(-,root,root,-)
>   rather then:
> %defattr(-, root, root)

done

> - There is no need to specify dir owner ship and the files inside it if
>   you want the package to own the dir and all files, for example this:
> %dir %{_includedir}/spice-client-glib/
> %{_includedir}/spice-client-glib/*.h
>   Can be written simply as:
> %{_includedir}/spice-client-glib
>   Likewise for spice-client-gtk, also you could consider using
>   wildcards, condensing the %files devel to:
> %{_libdir}/libspice-client-g*.so
> %{_includedir}/spice-client-g*
> %{_libdir}/pkgconfig/spice-client-g*.pc  
> %{_datadir}/gir-1.0/SpiceClientG*-1.0.gir
> %doc %{_datadir}/gtk-doc/html/*

done

http://fedorapeople.org/gitweb?p=elmarco/public_git/spice-gtk.git;a=commitdiff;h=59051f0de1772fadf1fd5ad6661d595585148279;hp=16c5fea8350282425bfe4d36ce4d4c5a9e381304

The SRPM is actually made from a git snapshot of version 0.3.20, which has a
broken python module bug.

I propose we wait until 0.4 release.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.