[Bug 664204] Review Request: perl-BackPAN-Index - Interface to the BackPAN index

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664204

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Petr Pisar <ppisar at redhat.com> 2011-01-05 08:00:08 EST ---
Spec file changes:
--- perl-BackPAN-Index.spec 2010-12-19 08:31:43.000000000 +0100
+++ perl-BackPAN-Index.spec.1 2011-01-05 06:43:19.000000000 +0100
@@ -1,6 +1,6 @@
 Name:           perl-BackPAN-Index
 Version:        0.39
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Interface to the BackPAN index
 License:        GPL+ or Artistic
 Group:          Development/Libraries
@@ -16,12 +16,16 @@
 BuildRequires:  perl(DBD::SQLite) >= 1.25
 BuildRequires:  perl(DBIx::Class) >= 0.08109
 BuildRequires:  perl(DBIx::Class::Schema::Loader) >= 0.05003
+BuildRequires:  perl(File::Path)
+BuildRequires:  perl(File::Spec)
+BuildRequires:  perl(File::Spec::Unix)
 BuildRequires:  perl(LWP::Simple)
 BuildRequires:  perl(Module::Build)
 BuildRequires:  perl(parent)
 BuildRequires:  perl(Path::Class) >= 0.17
 BuildRequires:  perl(Test::Compile) >= 0.11
 BuildRequires:  perl(Test::More) >= 0.90
+BuildRequires:  perl(URI::file)
 Requires:       perl(CLASS) >= 1.00
 Requires:       perl(Class::Accessor::Fast)
 Requires:       perl(DBD::SQLite) >= 1.25
@@ -33,7 +37,10 @@
 # Parse::BACKPAN::Packages is deprecated in favor of BackPAN::Index
 Obsoletes:      perl-Parse-BACKPAN-Packages <= 0.35

-%{?perl_default_filter}
+%{?perl_default_filter:
+%filter_from_requires /perl(CLASS)$/d;/perl(Path::Class)$/d
+%perl_default_filter
+}

 %description
 This downloads, caches and parses the BackPAN index into a local database
@@ -64,6 +71,10 @@
 %{_mandir}/man3/*

 %changelog
+* Wed Jan 05 2011 Iain Arnell <iarnell at gmail.com> 0.39-2
+- additional buildrequires for dual-lived modules
+- filter underspecified requires
+
 * Sun Dec 19 2010 Iain Arnell <iarnell at gmail.com> 0.39-1
 - Specfile autogenerated by cpanspec 1.78.
 - obsoletes perl-Parse-BACKPAN-Packages


> FIX: BuildRequire perl(File::Spec) (t/lib/TestUtils.pm:6) as it can dual-live
> in the future (http://search.cpan.org/~smueller/PathTools/).
+BuildRequires:  perl(File::Spec)
Ok.

> FIX: BuildRequire perl(File::Path) (t/lib/TestUtils.pm:7) as it can dual-live
> in the future (http://search.cpan.org/~dland/File-Path/).
>
+BuildRequires:  perl(File::Path)
Ok.

> FIX: BuildRequire perl(URI::file) (t/lib/TestUtils.pm:28)
+BuildRequires:  perl(URI::file)
Ok.

> FIX: BudilRequire perl(File::Spec::Unix) (t/lib/TestUtils.pm:29)
>
+BuildRequires:  perl(File::Spec::Unix)
Ok.

> TODO: Filter underspecified perl(CLASS) Requires.
> TODO: Filter underspecified perl(Path::Class) Requires.
>
+%filter_from_requires /perl(CLASS)$/d;/perl(Path::Class)$/d

$ rpm -pq --requires ../RPMS/noarch/perl-BackPAN-Index-0.39-2.fc14.noarch.rpm |
sort |uniq -c |xclip -in
      1 perl(App::Cache) >= 0.37
      1 perl(Archive::Extract)  
      1 perl(autodie)  
      1 perl(BackPAN::Index)  
      1 perl(BackPAN::Index::Role::AsHash)  
      1 perl(BackPAN::Index::Schema)  
      1 perl(base)  
      1 perl(Class::Accessor::Fast)  
      1 perl(CLASS) >= 1.00
      1 perl(CPAN::DistnameInfo) >= 0.09
      1 perl(DBD::SQLite) >= 1.25
      1 perl(DBIx::Class::Schema::Loader) >= 0.05003
      1 perl(DBIx::Class) >= 0.08109
      1 perl(File::Basename)  
      1 perl(File::stat)  
      1 perl(LWP::Simple)  
      1 perl(:MODULE_COMPAT_5.12.2)  
      1 perl(parent)  
      1 perl(Path::Class) >= 0.17
      1 perl(strict)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      2 rpmlib(VersionedDependencies) <= 3.0.3-1
Binary requires Ok.

> 
> Package does not build in F15
> (http://koji.fedoraproject.org/koji/taskinfo?taskID=2700482) because of bug in
> perl-DBI.
> POSTPONE: This review will be suspended until fix of the perl-DBI in F15.
> 
Package builds in F14
(http://koji.fedoraproject.org/koji/getfile?taskID=2702183&name=build.log).
Problem in F15 is just a temporary issue. Ok.

Resolution: Package APPROVED.
Notice: Build for F15 after fixing perl-DBI (emerging perl-Core).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.