[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=666763

--- Comment #13 from Guido Trentalancia <guido at trentalancia.com> 2011-01-05 14:30:18 EST ---
Hi Martin,

thanks again for your thoughtful comments !

- Fixed the third issue (in rel 6), very good point I had forgotten that !
- Fixed the init script and the spec for the chkconfig issue (rel 6), although
in truth it's not a "network listening" thing, it has nothing to do with
network interfaces, not even the ax25 ones (which could well be inactive), it
just deals with the serial interface to which, supposedly, a TNC is connected;
and also, have a look below...
- The very last issue, from my understanding, is about the manual page being
compressed using gzip rather than bz2 and possibly this is something to do with
the fact that I am using rpmlint from upstream. Anyway, something not to bother
with...

But then, have a look at what happens with the binary package after removing
completely %post and %postun:

ax_emergency_listen.i386: E: init-script-without-chkconfig-postin
/etc/rc.d/init.d/ax_emergency_listen
ax_emergency_listen.i386: E: init-script-without-chkconfig-preun
/etc/rc.d/init.d/ax_emergency_listen
ax_emergency_listen.i386: W: no-default-runlevel
/etc/rc.d/init.d/ax_emergency_listen
ax_emergency_listen.i386: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/ax_emergency_listen

and after re-adding %post and %postun:

ax_emergency_listen.i386: W: no-default-runlevel
/etc/rc.d/init.d/ax_emergency_listen
ax_emergency_listen.i386: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/ax_emergency_listen

I have just followed the Guidelines and your suggestions.

Of course, rpmlint on the SRPMS is clean.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.