[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647885

--- Comment #15 from Stanislav Ochotnicky <sochotni at redhat.com> 2011-01-06 09:17:14 EST ---
So...Few more things:
 * rm -rf $RPM_BUILD_ROOT in %install is not needed
 * you shouldn't install BUILD.txt
 * you probably didn't see my note about useless Requires where:

apache-rat-core -> apache-rat -> jpackage utils
                -> jpackage-utils

the requires on jpackage-utils in core is not needed because it is pulled in by
main package. Similar other requires like this are in the spec. It's not
exactly a packaging problem, but makes the spec file bigger without any reason
(that I can see). If you have a reason for this, please explain. 

All in all the package is good now, but I'll wait for new version/response
before accepting...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.