[Bug 638647] Review Request: mom - Dynamically manage system resources on virtualization hosts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638647

--- Comment #21 from Michael Schwendt <mschwendt at gmail.com> 2011-01-07 04:59:01 EST ---
Richard, you must be the reviewer if you want to be the sponsor:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored

| Review and approval for the first package for new packagers
| must be done by registered sponsors. Subsequent reviews can be done
| by any package maintainer. Informal reviews can always be done by
| anyone interested.

https://fedoraproject.org/wiki/How_to_sponsor_a_new_contributor
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

[...]

> %files
> ...
> %{_defaultdocdir}/%{name}-%{version}/*

Notice that directory %{_defaultdocdir}/%{name}-%{version} is not included:
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

Better replace the line with just:
%{_defaultdocdir}/%{name}-%{version}/

which includes the directory and its contents. The trailing slash is just for
readability (to make more clear that the entry is for a directory).

Also be aware that explicitly including files in
%{_defaultdocdir}/%{name}-%{version} conflicts with using %doc to include
documentation files. As it's a common pitfall for packagers, I recommend you
add a comment to the %files section that %doc MUST NOT be used to include
further documentation files as long as %{_defaultdocdir}/%{name}-%{version} is
used. With recent distribution releases there will be an error. With older
ones, you would kill files without any error/warning.


> Requires:       libvirt, libvirt-python

Even if it may be obvious to insiders, please add a comment here that explains
why these two Explicit Requires are necessary:
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.