[Bug 592487] Review Request: ffgtk - A solution for controlling Fritz!Box or compatible routers
bugzilla at redhat.com
bugzilla at redhat.com
Sat Jan 8 00:33:55 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592487
Jason Tibbitts <tibbs at math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |tibbs at math.uh.edu
Flag| |fedora-review?
--- Comment #13 from Jason Tibbitts <tibbs at math.uh.edu> 2011-01-07 19:33:52 EST ---
I don't see that clarification from the author included in the package. As I
wrote before in comment 6, you need to include the email from the author with
headers in the package as documentation, or you can package the updated version
that has the fixed manpage. Of course, the author of the code should still
follow the directions in the GPL itself and include proper license blocks in
the code.
AUTHORS, COPYING, ChangeLog, README and README.Fedora seem to be duplicated
between each package. You should not duplicate files in that manner. All of
the packages require ffgtk, so placing that information in the ffgtk package
should be sufficient.
I'm unsure about the scriptlets. The dependencies for them seem to be missing,
for one, but even then, I don't understand the point of setting up a printer if
cups happens to be running at the moment the package is installed (or
upgraded). That seems rather nondeterministic. Wouldn't it be best to leave
management of the printer to the end user?
This package, like many, bundles one of the md5.c implementations. I've
requested that FPC give this a blanket exemption as a copylib.
* source files match upstream. sha256sum:
185605137e1c591c6585cbe6a810689365ff5033652064a5d678def52f7485d3
ffgtk-0.7.8.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
X license clarification not include in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
X final provides and requires; capifax subpackage is missing scripelet
dependencies.
ffgtk-0.7.8-2.fc15.x86_64.rpm
lib_ab_fritzfon.so.0()(64bit)
lib_ab_local.so.0()(64bit)
lib_ab_thunderbird.so.0()(64bit)
lib_ab_vcard.so.0()(64bit)
lib_audio_ao.so.0()(64bit)
lib_pwd_gnome.so.0()(64bit)
ffgtk = 0.7.8-2.fc15
ffgtk(x86-64) = 0.7.8-2.fc15
=
lib_ab_fritzfon.so.0()(64bit)
lib_ab_local.so.0()(64bit)
lib_ab_thunderbird.so.0()(64bit)
lib_ab_vcard.so.0()(64bit)
lib_audio_ao.so.0()(64bit)
lib_pwd_gnome.so.0()(64bit)
libao.so.4()(64bit)
libatk-1.0.so.0()(64bit)
libcairo.so.2()(64bit)
libcurl.so.4()(64bit)
libdbus-1.so.3()(64bit)
libdbus-glib-1.so.2()(64bit)
libfontconfig.so.1()(64bit)
libfreetype.so.6()(64bit)
libgdk-x11-2.0.so.0()(64bit)
libgdk_pixbuf-2.0.so.0()(64bit)
libgio-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgmodule-2.0.so.0()(64bit)
libgnome-keyring.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgstapp-0.10.so.0()(64bit)
libgstbase-0.10.so.0()(64bit)
libgstinterfaces-0.10.so.0()(64bit)
libgstreamer-0.10.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libgtk-x11-2.0.so.0()(64bit)
libpango-1.0.so.0()(64bit)
libpangocairo-1.0.so.0()(64bit)
libpangoft2-1.0.so.0()(64bit)
libpng12.so.0()(64bit)
libsndfile.so.1()(64bit)
libsndfile.so.1(libsndfile.so.1.0)(64bit)
libspeex.so.1()(64bit)
libxml2.so.2()(64bit)
libxml2.so.2(LIBXML2_2.4.30)(64bit)
ffgtk-plugin-capifax-0.7.8-2.fc15.x86_64.rpm
lib_fax_capifax.so.0()(64bit)
ffgtk-plugin-capifax = 0.7.8-2.fc15
ffgtk-plugin-capifax(x86-64) = 0.7.8-2.fc15
=
/bin/sh
cups
ffgtk = 0.7.8-2.fc15
ghostscript
lib_fax_capifax.so.0()(64bit)
libcapifax.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
ffgtk-plugin-evolution-0.7.8-2.fc15.x86_64.rpm
lib_ab_ebook.so.0()(64bit)
ffgtk-plugin-evolution = 0.7.8-2.fc15
ffgtk-plugin-evolution(x86-64) = 0.7.8-2.fc15
=
ffgtk = 0.7.8-2.fc15
lib_ab_ebook.so.0()(64bit)
libcamel-1.2.so.21()(64bit)
libebook-1.2.so.10()(64bit)
libedataserver-1.2.so.14()(64bit)
libgconf-2.so.4()(64bit)
libgio-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgmodule-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libnspr4.so()(64bit)
libnss3.so()(64bit)
libnssutil3.so()(64bit)
libplc4.so()(64bit)
libplds4.so()(64bit)
libsmime3.so()(64bit)
libsoup-2.4.so.1()(64bit)
libsqlite3.so.0()(64bit)
libssl3.so()(64bit)
libxml2.so.2()(64bit)
ffgtk-plugin-gstreamer-0.7.8-2.fc15.x86_64.rpm
lib_audio_gstreamer.so.0()(64bit)
ffgtk-plugin-gstreamer = 0.7.8-2.fc15
ffgtk-plugin-gstreamer(x86-64) = 0.7.8-2.fc15
=
ffgtk = 0.7.8-2.fc15
lib_audio_gstreamer.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgmodule-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgstapp-0.10.so.0()(64bit)
libgstbase-0.10.so.0()(64bit)
libgstinterfaces-0.10.so.0()(64bit)
libgstreamer-0.10.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libxml2.so.2()(64bit)
? md5.c seems bundled libraries.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
X many duplicates in %files.
* file permissions are appropriate.
* no generically named files.
? unsure about the scriptlets
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no static libraries.
* desktop files valid and installed properly.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list