[Bug 637212] Review Request: yubikey-ksm - The YubiKey Key Storage Module

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 8 01:46:33 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


Ricky Zhou <rzhou at redhat.com> changed:

           What    |Removed                     |Added
         AssignedTo|nobody at fedoraproject.org    |rzhou at redhat.com
               Flag|                            |fedora-review+

--- Comment #3 from Ricky Zhou <rzhou at redhat.com> 2011-01-07 20:46:31 EST ---
X - rpmlint clean (normal google code warning)

yubikey-ksm.src: W: invalid-url Source0:
http://yubikey-ksm.googlecode.com/files/yubikey-ksm-1.5.tgz HTTP Error 404: Not

yubikey-ksm.noarch: W: incoherent-version-in-changelog 1.3-3 ['1.5-3.fc14',
yubikey-ksm.noarch: E: non-readable /etc/ykksm/ykksm-config.php 0640L
yubikey-ksm.noarch: W: no-manual-page-for-binary ykksm-export
yubikey-ksm.noarch: W: no-manual-page-for-binary ykksm-checksum
yubikey-ksm.noarch: W: no-manual-page-for-binary ykksm-gen-keys
yubikey-ksm.noarch: W: no-manual-page-for-binary ykksm-import
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

Non-readable error is false positive.
Minor issue - the last changelog entry in the spec uses the wrong
version, should bump version and reset the release.

OK - package meets naming guidelines
OK - spec file name matches base package name
OK - meets packaging guidelines
OK - meets licensing guidelines
OK - license field matches
OK - spec in American English
OK - spec is legible
OK - spec sources match upstream
OK - builds in mock
OK - no bundled libs
OK - owns its directories, does not own files owned by other packages
OK - does not list a file more than once
OK - permissions are OK
OK - consistently uses macros
OK - contains code or permissible content
OK - files in %doc do not affect runtime
OK - filenames valid UTF-8

SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.


Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list