[Bug 573848] Review Request: perl-NetPacket - Modules to assemble/disassemble network packets at the protocol level

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573848

Marcela Mašláňová <mmaslano at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(jan.klepek at gmail. |
                   |com)                        |

--- Comment #12 from Marcela Mašláňová <mmaslano at redhat.com> 2011-01-10 04:25:37 EST ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
http://koji.fedoraproject.org/koji/taskinfo?taskID=2711790
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -q --provides perl-NetPacket
perl(NetPacket) = 1.0.1
perl(NetPacket::ARP) = 1.0.1
perl(NetPacket::Ethernet) = 1.0.1
perl(NetPacket::ICMP) = 1.0.1
perl(NetPacket::IGMP) = 1.0.1
perl(NetPacket::IP) = 1.0.1
perl(NetPacket::TCP) = 1.0.1
perl(NetPacket::UDP) = 1.0.1
perl-NetPacket = 1.0.1-1.fc15

rpm -q --requires perl-NetPacket
perl(:MODULE_COMPAT_5.12.2)  
perl(NetPacket)  
perl(NetPacket::IP)  
perl(constant)  
perl(strict)  
perl(vars)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
rpmlib(PayloadIsXz) <= 5.2-1

Patch for EL-5 build looks fine.

ACCEPT

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.