[Bug 664817] Review Request: perl-HTML-Selector-XPath - CSS Selector to XPath compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664817

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2011-01-11 09:44:15 EST ---
Source tar ball is original. Ok.
Summary verified from lib/HTML/Selector/XPath.pm. Ok.
License verified from lib/HTML/Selector/XPath.pm. Ok.
Description verified from lib/HTML/Selector/XPath.pm. Ok.

FIX: BuildRequire perl(Exporter) (lib/HTML/Selector/XPath.pm:7) as it can
dual-live in the future (http://search.cpan.org/~ferreira/Exporter/).

All test passes. Ok.

$ rpmlint perl-HTML-Selector-XPath.spec
../SRPMS/perl-HTML-Selector-XPath-0.04-1.fc14.src.rpm
../RPMS/noarch/perl-HTML-Selector-XPath-0.04-1.fc14.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-HTML-Selector-XPath-0.04-1.fc14.noarch.rpm 
drwxr-xr-x    2 root    root                        0 led 11 15:33
/usr/share/doc/perl-HTML-Selector-XPath-0.04
-rw-r--r--    1 root    root                      447 úno 27  2010
/usr/share/doc/perl-HTML-Selector-XPath-0.04/Changes
-rw-r--r--    1 root    root                      558 úno 27  2010
/usr/share/doc/perl-HTML-Selector-XPath-0.04/README
-rw-r--r--    1 root    root                     2517 led 11 15:33
/usr/share/man/man3/HTML::Selector::XPath.3pm.gz
drwxr-xr-x    2 root    root                        0 led 11 15:33
/usr/share/perl5/HTML
drwxr-xr-x    2 root    root                        0 led 11 15:33
/usr/share/perl5/HTML/Selector
-rw-r--r--    1 root    root                     6059 úno 27  2010
/usr/share/perl5/HTML/Selector/XPath.pm
File permissions and layout Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-HTML-Selector-XPath-0.04-1.fc14.noarch.rpm | sort | uniq -c
      1 perl(Carp)  
      1 perl(Exporter)  
      1 perl(:MODULE_COMPAT_5.12.2)  
      1 perl(strict)  
      1 perl >= 0:5.008_001
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rpmlib(VersionedDependencies) <= 3.0.3-1
Binary requires Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-HTML-Selector-XPath-0.04-1.fc14.noarch.rpm | sort | uniq -c
      1 perl(HTML::Selector::XPath) = 0.04
      1 perl-HTML-Selector-XPath = 0.04-1.fc14
Binary provides Ok.

$ resolvedeps-f15
../RPMS/noarch/perl-HTML-Selector-XPath-0.04-1.fc14.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2714859). Ok.

Otherwise package is in line with Fedora and perl packaging guidelines.


Please correct all `FIX' prefixed issues and provide new spec file.
Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.