[Bug 666954] Review Request: cherrytree - Hierarchical note taking application

bugzilla at redhat.com bugzilla at redhat.com
Tue Jan 11 15:32:14 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=666954

--- Comment #13 from Robin Lee <robinlee.sysu at gmail.com> 2011-01-11 10:32:13 EST ---
About eggs, refer to
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns
.

In the case of cherrytree, it is the second case of the above definitions of
eggs.

Including the egg is a 'Should' but not a 'Must', and for cherrytree, the
egg-info file is useless.

But if nothing was installed to %{python_sitelib}, the 'python(abi)'
requirement will not be auto-generated.

After all, just include the egg.


New rpmlint result:
$ rpmlint ./cherrytree-0.19.1-1.fc14.noarch.rpm 
cherrytree.noarch: W: spelling-error %description -l en_US xml -> XML, cml, ml
cherrytree.noarch: W: spelling-error %description -l en_US ctd -> cts, ct, cd
cherrytree.noarch: W: devel-file-in-non-devel-package
/usr/share/cherrytree/glade/cherrytree.glade.h
cherrytree.noarch: E: script-without-shebang
/usr/share/applications/cherrytree.desktop
cherrytree.noarch: W: no-manual-page-for-binary cherrytree
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

* TODO: The header file is included again. 
* TODO: Add 'chmod -x linux/cherrytree.desktop' to %prep and notify upstream.
And you may notify upstream of these issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list