[Bug 653435] Review Request: perl-Catalyst-Engine-PSGI - PSGI engine for Catalyst

bugzilla at redhat.com bugzilla at redhat.com
Tue Jan 11 16:49:33 UTC 2011 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653435

--- Comment #3 from Petr Pisar <ppisar at redhat.com> 2011-01-11 11:49:31 EST ---
Spec file changes:
--- perl-Catalyst-Engine-PSGI.spec 2010-11-15 13:59:23.000000000 +0100
+++ perl-Catalyst-Engine-PSGI.spec.1 2011-01-11 15:05:00.000000000 +0100
@@ -1,6 +1,6 @@
 Name:           perl-Catalyst-Engine-PSGI
 Summary:        PSGI engine for Catalyst
-Version:        0.11
+Version:        0.12
 Release:        1%{?dist}
 License:        GPL+ or Artistic
 Group:          Development/Libraries
@@ -13,11 +13,49 @@
 BuildRequires:  perl(Catalyst::Runtime) >= 5.80007
 BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.42
 BuildRequires:  perl(Filter::Util::Call)
+BuildRequires:  perl(File::Spec)
+BuildRequires:  perl(Moose)
+BuildRequires:  perl(Scalar::Util)
+BuildRequires:  perl(URI)
+BuildRequires:  perl(MyApp)
+
+
+#Tests dependencies:
+BuildRequires:  perl(Plack::Loader)
+BuildRequires:  perl(Test::More)
+BuildRequires:  perl(Test::Requires)
+BuildRequires:  perl(lib)
+BuildRequires:  perl(LWP::UserAgent)
+BuildRequires:  perl(Catalyst)
+BuildRequires:  perl(Catalyst::Utils)
+#BuildRequires:  perl(Moose::Utils)
+BuildRequires:  perl(namespace::clean)
+BuildRequires:  perl(MooseX::MethodAttributes)
+BuildRequires:  perl(Moose::Role)
+BuildRequires:  perl(YAML)
+BuildRequires:  perl(HTML::Entities)
+BuildRequires:  perl(Data::Dumper)
+BuildRequires:  perl(MRO::Compat)
+BuildRequires:  perl(FindBin)
+BuildRequires:  perl(Benchmark)
+BuildRequires:  perl(Catalyst::Request)
+BuildRequires:  perl(Catalyst::Request::Upload)
+BuildRequires:  perl(HTTP::Body::OctetStream)
+BuildRequires:  perl(HTTP::Headers)
+BuildRequires:  perl(HTTP::Headers::Util)
+BuildRequires:  perl(HTTP::Request::Common)
+BuildRequires:  perl(Path::Class::Dir)
+BuildRequires:  perl(CGI::Simple::Cookie)
+BuildRequires:  perl(Getopt::Long)
+BuildRequires:  perl(Pod::Usage)
+BuildRequires:  perl(Catalyst::Engine::HTTP)
+BuildRequires:  perl(Catalyst::Restarter)
+BuildRequires:  perl(Test::Pod::Coverage) >= 1.04

 Requires:       perl(Catalyst::Action::RenderView)
 Requires:       perl(Catalyst::Runtime) >= 5.80007
 Requires:       perl(Filter::Util::Call)
-
+Requires:       perl(Plack::Loader)

 %{?perl_default_filter}
 %{?perl_default_subpackage_tests}
@@ -49,11 +87,14 @@

 %files
 %defattr(-,root,root,-)
-%doc Changes README Changes README
+%doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*.3*

 %changelog
+* Tue Jan 11 2011 Marcela Mašláňová <mmaslano at redhat.com> 0.12-1
+- update to 0.12
+
 * Mon Nov 15 2010 Marcela Mašláňová <mmaslano at redhat.com> 0.11-1
 - specfile by Fedora::App::MaintainerTools 0.006


Source tar ball is original. Ok.

Sources perl requires changes:
$ diff -Naur Catalyst-Engine-PSGI-0.1{1,2}/ | grep '^[+-]' | grep -E
'\<(use|require)\>'
-use 5.008000;
+use 5.006000;
+use Fcntl ':flock';
+use Config;
-use Test::SharedFork;
+use Test::SharedFork 0.12;
+use Carp ();


> FIX: BuildRequire perl(File::Spec) as it can dual-live in the future
> (lib/Catalyst/Helper/PSGI.pm:4, http://search.cpan.org/~smueller/PathTools/)
+BuildRequires:  perl(File::Spec)
Ok.

> FIX: BuildRequire perl(Moose) (lib/Catalyst/Engine/PSGI.pm:7:use Moose)
+BuildRequires:  perl(Moose)
Ok.

> FIX: BuildRequire perl(Scalar::Util) as it can dual-live in the future
(lib/Catalyst/Engine/PSGI.pm:20,
http://search.cpan.org/~gbarr/Scalar-List-Utils/)
+BuildRequires:  perl(Scalar::Util)
Ok.

> FIX: BuildRequire perl(URI) (lib/Catalyst/Engine/PSGI.pm:21)
+BuildRequires:  perl(URI)
Ok.

> FIX: BuildRequire perl(MyApp) (lib/Catalyst/Engine/PSGI.pm:210)
+BuildRequires:  perl(MyApp)
Ok.

> FIX: BuildRequire perl(Plack::Loader) (lib/Plack/Test/Adopt/Catalyst.pm:9)
+BuildRequires:  perl(Plack::Loader)
Ok.

> FIX: BuildRequire perl(Test::More) (t/hello.t:2)
+BuildRequires:  perl(Test::More)
Ok.

> FIX: BuildRequire perl(Test::Requires) (t/hello.t:3)
+BuildRequires:  perl(Test::Requires)
Ok.

> FIX: BuildRequire perl(lib) as it can dual-live in the future (t/hello.t:4,
> http://search.cpan.org/~smueller/lib/)
+BuildRequires:  perl(lib)
Ok.

> FIX: BuildRequire perl(LWP::UserAgent) (t/hello.t:6)
+BuildRequires:  perl(LWP::UserAgent)
Ok.

> FIX: BuildRequire perl(Catalyst)
> (t/catalyst/lib/TestAppChainedAbsolutePathPart.pm:4)
+BuildRequires:  perl(Catalyst)
Ok.

> FIX: BuildRequire perl(Catalyst::Utils)
> (t/catalyst/lib/TestAppChainedAbsolutePathPart.pm:8)
+BuildRequires:  perl(Catalyst::Utils)
Ok.

> FIX: BuildRequire perl(Moose::Utils)
> (t/catalyst/lib/TestApp/Controller/Anon.pm:13)
+#BuildRequires:  perl(Moose::Utils)
Build-time dependency removed from 0.12 sources. Ok.

> FIX: BuildRequire perl(namespace::clean)
> (t/catalyst/lib/TestApp/Controller/Moose.pm:5)
+BuildRequires:  perl(namespace::clean)
Ok.

> FIX: BuildRequire perl(MooseX::MethodAttributes)
> (t/catalyst/lib/TestApp/Controller/Moose.pm:8)
+BuildRequires:  perl(MooseX::MethodAttributes)
Ok.

> FIX: BuildRequire perl(Moose::Role)
> (t/catalyst/lib/TestApp/Controller/Immutable/HardToReload.pm:2)
+BuildRequires:  perl(Moose::Role)
Ok.

> FIX: BuildRequire perl(YAML) (t/catalyst/lib/TestApp/Controller/Fork.pm:11)
+BuildRequires:  perl(YAML)
Ok.

> FIX: BuildRequire perl(HTML::Entities)
> (t/catalyst/lib/TestApp/Controller/Action/Chained.pm:6)
+BuildRequires:  perl(HTML::Entities)
Ok.

> FIX: BuildRequire perl(Data::Dumper) (t/catalyst/lib/TestApp/View/Dump.pm:6)
+BuildRequires:  perl(Data::Dumper)
Ok.

> FIX: BuildRequire perl(MRO::Compat) (t/catalyst/lib/CDICompatTestPlugin.pm:18)
+BuildRequires:  perl(MRO::Compat)
Ok.

> FIX: BuildRequire perl(FindBin)
> (t/catalyst/aggregate/live_component_controller_action_begin.t:6)
+BuildRequires:  perl(FindBin)
Ok.

> FIX: BuildRequire perl(Benchmark)
> (t/catalyst/aggregate/live_component_controller_action_begin.t:17)
+BuildRequires:  perl(Benchmark)
Ok.

> FIX: BuildRequire perl(Catalyst::Request)
> (t/catalyst/aggregate/live_engine_request_uploads.t:12)
+BuildRequires:  perl(Catalyst::Request)
Ok.

> FIX: BuildRequire perl(Catalyst::Request::Upload)
> (t/catalyst/aggregate/live_engine_request_uploads.t:13)
+BuildRequires:  perl(Catalyst::Request::Upload)
Ok.

> FIX: BuildRequire perl(HTTP::Body::OctetStream)
> (t/catalyst/aggregate/live_engine_request_uploads.t:14)
+BuildRequires:  perl(HTTP::Body::OctetStream)
Ok.

> FIX: BuildRequire perl(HTTP::Headers)
> (t/catalyst/aggregate/live_engine_request_uploads.t:15)
+BuildRequires:  perl(HTTP::Headers)
Ok.

> FIX: BuildRequire perl(HTTP::Headers::Util)
> (t/catalyst/aggregate/live_engine_request_uploads.t:16)
+BuildRequires:  perl(HTTP::Headers::Util)
Ok.

> FIX: BuildRequire perl(HTTP::Request::Common)
> (t/catalyst/aggregate/live_engine_request_uploads.t:17)
+BuildRequires:  perl(HTTP::Request::Common)
Ok.

> FIX: BuildRequire perl(Path::Class::Dir)
> (t/catalyst/aggregate/live_engine_request_uploads.t:18)
+BuildRequires:  perl(Path::Class::Dir)
Ok.

> FIX: BuildRequire perl(CGI::Simple::Cookie)
> (t/catalyst/aggregate/live_engine_request_cookies.t:13)
+BuildRequires:  perl(CGI::Simple::Cookie)
Ok.

> FIX: BuildRequire perl(Getopt::Long) (t/Hello/script/hello_fastcgi.pl:7)
+BuildRequires:  perl(Getopt::Long)
Ok.

> FIX: BuildRequire perl(Pod::Usage) (t/Hello/script/hello_fastcgi.pl)
+BuildRequires:  perl(Pod::Usage)
Ok.

> FIX: BuildRequire perl(Catalyst::Engine::HTTP)
> (t/Hello/script/hello_server.pl:6)
+BuildRequires:  perl(Catalyst::Engine::HTTP)
Ok.

> FIX: BuildRequire perl(Catalyst::Restarter) (t/Hello/script/hello_server.pl)
+BuildRequires:  perl(Catalyst::Restarter)
Ok.

> FIX: BuildRequire perl(Test::Pod::Coverage) >= 1.04
> (t/Hello/t/03podcoverage.t:6)
+BuildRequires:  perl(Test::Pod::Coverage) >= 1.04
Ok.

Following BuildRequires are bundled with sources for test purposes:
inc/Test/More.pm:2:package Test::More;
inc/Test/Requires.pm:2:package Test::Requires;
TODO: Remove the packages from sources before running tests to use distribution
packages or remove the BuildRequires (if possible).

TODO: Consider sorting BuildRequires lexicographically in the spec file to
achive better maintainance.

> FIX: Duplicate `Changes' and `README' files in %doc.
-%doc Changes README Changes README
+%doc Changes README
Ok.

All tests pass. Ok.

> FIX: permissions in  perl-Catalyst-Engine-PSGI-tests.noarch
$ rpmlint perl-Catalyst-Engine-PSGI.spec
../SRPMS/perl-Catalyst-Engine-PSGI-0.12-1.fc15.src.rpm
../RPMS/noarch/perl-Catalyst-Engine-PSGI-*0.12-*
perl-Catalyst-Engine-PSGI-tests.noarch: W: no-documentation
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_create.pl
0644L /usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_server.pl
0644L /usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/Makefile.PL 0644L
/usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello.psgi 0644L
/usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_test.pl
0644L /usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_cgi.pl 0644L
/usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_fastcgi.pl
0644L /usr/bin/env
3 packages and 1 specfiles checked; 7 errors, 1 warnings.

FIX: permissions in  perl-Catalyst-Engine-PSGI-tests.noarch

$ rpm -q -lv -p ../RPMS/noarch/perl-Catalyst-Engine-PSGI-0.12-1.fc15.noarch.rpm
drwxr-xr-x    2 root    root                        0 led 11 17:26
/usr/share/doc/perl-Catalyst-Engine-PSGI-0.12
-rw-r--r--    1 root    root                     1256 led  6 23:38
/usr/share/doc/perl-Catalyst-Engine-PSGI-0.12/Changes
-rw-r--r--    1 root    root                      563 zář  6  2009
/usr/share/doc/perl-Catalyst-Engine-PSGI-0.12/README
-rw-r--r--    1 root    root                     2033 led 11 17:26
/usr/share/man/man3/Catalyst::Controller::Metal.3pm.gz
-rw-r--r--    1 root    root                     2718 led 11 17:26
/usr/share/man/man3/Catalyst::Engine::PSGI.3pm.gz
-rw-r--r--    1 root    root                     1931 led 11 17:26
/usr/share/man/man3/Catalyst::Helper::PSGI.3pm.gz
-rw-r--r--    1 root    root                     1877 led 11 17:26
/usr/share/man/man3/Plack::Test::Adopt::Catalyst.3pm.gz
drwxr-xr-x    2 root    root                        0 led 11 17:26
/usr/share/perl5/vendor_perl/Catalyst
drwxr-xr-x    2 root    root                        0 led 11 17:26
/usr/share/perl5/vendor_perl/Catalyst/Controller
-rw-r--r--    1 root    root                     1015 pro 11  2009
/usr/share/perl5/vendor_perl/Catalyst/Controller/Metal.pm
drwxr-xr-x    2 root    root                        0 led 11 17:26
/usr/share/perl5/vendor_perl/Catalyst/Engine
-rw-r--r--    1 root    root                     7092 led  6 23:38
/usr/share/perl5/vendor_perl/Catalyst/Engine/PSGI.pm
drwxr-xr-x    2 root    root                        0 led 11 17:26
/usr/share/perl5/vendor_perl/Catalyst/Helper
-rw-r--r--    1 root    root                      913 dub  8  2010
/usr/share/perl5/vendor_perl/Catalyst/Helper/PSGI.pm
drwxr-xr-x    2 root    root                        0 led 11 17:26
/usr/share/perl5/vendor_perl/Plack
drwxr-xr-x    2 root    root                        0 led 11 17:26
/usr/share/perl5/vendor_perl/Plack/Test
drwxr-xr-x    2 root    root                        0 led 11 17:26
/usr/share/perl5/vendor_perl/Plack/Test/Adopt
-rw-r--r--    1 root    root                     1973 říj 13  2009
/usr/share/perl5/vendor_perl/Plack/Test/Adopt/Catalyst.pm
File pemissions and layout of main package Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Catalyst-Engine-PSGI-0.12-1.fc15.noarch.rpm | sort | uniq
-c
      1 perl(App::Prove)  
      1 perl(Catalyst::Action::RenderView)  
      1 perl(Catalyst::Controller::Metal)  
      1 perl(Catalyst::Engine::PSGI)  
      1 perl(Catalyst::Runtime) >= 5.80007
      1 perl(Class::MOP)  
      1 perl(File::Spec)  
      1 perl(Filter::Util::Call)  
      1 perl(:MODULE_COMPAT_5.12.2)  
      1 perl(Moose)  
      2 perl(Plack::Loader)  
      1 perl(Scalar::Util)  
      1 perl(strict)  
      1 perl(Test::TCP)  
      1 perl(URI)  
      1 perl(warnings)  
      1 perl >= 0:5.008_001
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(VersionedDependencies) <= 3.0.3-1
FIX: Duplicate perl(Plack::Loader). Remove explicit one from spec file.

$ rpm -q --provides -p
../RPMS/noarch/perl-Catalyst-Engine-PSGI-0.12-1.fc15.noarch.rpm | sort | uniq
-c
      1 perl(Catalyst::Controller::Metal)  
      1 perl(Catalyst::Engine::PSGI) = 0.12
      1 perl-Catalyst-Engine-PSGI = 0.12-1.fc15
      1 perl(Catalyst::Helper::PSGI)  
      1 perl(Plack::Test::Adopt::Catalyst)
Binary provides Ok.

> FIX: perl(Plack::Loader) symbol is not provided by any package in F-15.
$ resolvedeps-f15 ../RPMS/noarch/perl-Catalyst-Engine-PSGI-*0.12-*
Binary dependencies resolvable. Ok.

Package builds in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2715094). Ok.

Otherwise package is in line with Fedora and perl pacakaging guidelines.

Please correct all `FIX' prefixed issues and provide new spec file. Please
consider fixing `TODO' issues.
Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list