[Bug 668542] Review Request: php-pChart - A PHP class to build charts.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668542

Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
         AssignedTo|nobody at fedoraproject.org    |jochen at herr-schmitt.de
               Flag|                            |fedora-review?

--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de> 2011-01-11 13:11:45 EST ---
Good:
+ Base name of the SPEC files matches to package name.
+ Package fullfill naming guidelines
+ Package is build for noarch
+ Package cleans the buildroot in the %clean and %install section
+ Package contains no subpackages


Bad:
- This is not the most current release. On upstream I have found a note about
the release of 1.27c
- I would make the removement of the CRs in the example file into a loop.
- Why to you refer to %{_datadir}/doc/%{name} directory in the %doc stanza
- Please create a separate font package, because yoyur package contains fonts
- Package contains no verbatin copy of the license text. Please contact
upstream for including on to the upstream distributation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.