[Bug 646606] Rename review: drupal-workspace -> drupal6-workspace

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646606

Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
         AssignedTo|nobody at fedoraproject.org    |jochen at herr-schmitt.de
               Flag|                            |fedora-review?

--- Comment #5 from Jochen Schmitt <jochen at herr-schmitt.de> 2011-01-11 13:43:57 EST ---
Good:
+ Basename of the SPEC file matches with package name.
+ Package contains most recent version of the application
+ Download of the upstream tar ball via spectool -g works fine
+ Packaged tar ball matches with upstream
(md5sum: 31c3096654914eb2c58971de355d21a8)
+ Package contains valid BuildRoot definition
+ Package will build for noarch
* Package contains a License tag
* License tag specified GPL as a OSS license
+ Package contains verbatin copy of the license text
+ Local build works fine
+ Rpmlint is silent on source rpm
+ Scratch build works fine on koji
+ All files in the file stanza are own by this package
+ Files in the package has prpoer file permissions
+ There a no files with the same name in ohter package
+ %doc stanza is small, no we don't need a separate doc subpackage


Bad:
- Package should contains Provides: %{name} = %{version}-%{release}
- Rpmlint comlaints on binary rpm:
$ rpmlint drupal6-workspace-6.x.1.4-3.rc1.fc14.noarch.rpm 
drupal6-workspace.noarch: W: obsolete-not-provided drupal-workspace
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
- Because this package contains a prerelease, the releasenumber should start
with 0.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.