[Bug 668542] Review Request: php-pChart - A PHP class to build charts.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668542

--- Comment #2 from Jeffrey Ness <jeffrey.ness at rackspace.com> 2011-01-11 14:02:04 EST ---
Hello Jochen,

Thanks for your time, below I addressed your recommendations above:

- This is not the most current release. On upstream I have found a note about
the release of 1.27c

  SOURCE/generate-tarball.sh script does pull the latest version (1.27d), I
have updated the SPEC to reflect this
(http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning)

- I would make the removement of the CRs in the example file into a loop.

  I now call all Example files as Example*.php

- Why to you refer to %{_datadir}/doc/%{name} directory in the %doc stanza

  This has been changed to Example*.php

- Please create a separate font package, because yoyur package contains fonts

  The SPEC file removes the fonts as it is not required (not licensed
properly), any TrueType font can be used (such as liberation-fonts).

- Package contains no verbatin copy of the license text. Please contact
upstream for including on to the upstream distributation.

  Notified upstream:
 
https://sourceforge.net/projects/pchart/forums/forum/822589/topic/3943092/index/page/1

---

Spec URL: http://flip-edesign.com/source/php-pChart/php-pChart.spec
SRPM URL:
http://flip-edesign.com/source/php-pChart/php-pChart-1.27d-5.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.