[Bug 668839] Review Request: pki-core

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 14 04:16:14 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668839

--- Comment #5 from Matthew Harmsen <mharmsen at redhat.com> 2011-01-13 23:16:12 EST ---
MODIFIED SPEC URL:
http://mharmsen.fedorapeople.org/pki-core.spec

MODIFIED SRPM URL:
http://mharmsen.fedorapeople.org/pki-core-9.0.0-3.fc12.src.rpm


Addressed "TO_DO" items mentioned in Comment #3.


Addressed remaining 'rpmlint' issues addressed in Comment #4 with the exception
of the following:

ERROR:
pki-ca.noarch: E: subsys-not-used /etc/rc.d/init.d/pki-cad

EXPLANATION:
I do not believe that this is an error because 'pki-cad' DOES use a lock file
located under "/var/lock/subsys'.  This lockfile is contained in
'/usr/share/pki/scripts/functions' which is included in
'/etc/rc.d/init.d/pki-cad'.


ERROR:
pki-setup.noarch: E: script-without-shebang /usr/share/pki/scripts/pkicommon.pm

EXPLANATION:
I do not believe that this is an error because first line in the file
'/usr/share/pki/scripts/pkicommon.pm' is "#!/usr/bin/perl" and the permissions
on the file within the RPM and when installed are "-rwxr-xr-x".


WARNINGS TO BE ADDRESSED:
Bugzilla Bug #616096 - PKI packages do not have man pages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list