[Bug 669407] Review Request: ledmon - LED control app for Intel(R) storage controllers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669407

Ondrej Vasik <ovasik at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

--- Comment #7 from Ondrej Vasik <ovasik at redhat.com> 2011-01-14 08:19:16 EST ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OK      source files match upstream:

sha256sum ledmon-0.1.tar.gz ledmon-0.1.tar.gz.orig 
12d8c843a539d6b61be0d4f5c6394d7a8bc89cda60512ee6f1316dca9676736d 
ledmon-0.1.tar.gz
12d8c843a539d6b61be0d4f5c6394d7a8bc89cda60512ee6f1316dca9676736d 
ledmon-0.1.tar.gz.orig

Just for record, sha256sums of other checked components:
sha256sum ledmon.spec ledmon-0.1-2.fc14.src.rpm     
8bfbf9318e87857751ad05b00e89fec52e1a5d0627c8da91803b3d393641879c  ledmon.spec
627302904840afa2269db1b2bc13e7f3064cc2f1ed78baa740da59ddbff3761b 
ledmon-0.1-2.fc14.src.rpm

OK      package meets naming and versioning guidelines.
OK      specfile is properly named, is cleanly written and uses macros
consistently.
OK      dist tag is present.
OK      license field matches the actual license.
        GPLv2+
OK     license is open source-compatible. License text included in package.
        GPLv2+
OK      latest version is being packaged.
OK     BuildRequires are proper.

        pod2man required for manpage generating, so BuildRequires: perl could
be added for safety, however - perl is part of dependency tree of the basic
buildtree so not required.

OK   compiler flags are appropriate.
OK      package builds in mock (Rawhide/i686).
OK      debuginfo package looks complete.
BAD     rpmlint is silent.

$ rpmlint ledmon-0.1-2*.rpm ledmon.spec               
ledmon.src: W: spelling-error %description -l en_US ledctl -> ledger, ledge,
Leda
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

OK     final provides and requires look sane.
N/A     %check is present and all tests pass.
N/A      shared libraries are added to the regular linker search paths with
proper scriptlets
OK      owns the directories it creates.
OK      doesn't own any directories it shouldn't.
OK      no duplicates in %files.
OK      file permissions are appropriate.
OK      correct scriptlets present.
OK      code, not content.
OK      documentation is small, so no -docs subpackage is necessary.
OK      %docs are not necessary for the proper functioning of the package.
OK      headers in -devel
OK      pkgconfig files in -devel
OK      no libtool .la droppings.
OK      not a GUI app.
OK      obsoletes and provides of the obsoleted package are valid

Maybe just one comment ledctl.conf manpage is at the moment useless (utilities
don't use conf files at the moment) and may be a bit confusing. I think it
would be safer to not ship it. 

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.