[Bug 652623] Review Request: erlang-bitcask - Eric Brewer-inspired key/value store

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652623

--- Comment #4 from Peter Lemenkov <lemenkov at gmail.com> 2011-01-14 09:37:41 EST ---
(In reply to comment #3)
> - I'd like the build system to be even more verbose. For erl compiles it only
> outputs "Compiled src/bitcask_merge_worker.erl" or so. Could it also output the
> ecc call? (I'm assuming it's using ecc.) For C compiles it outputs something
> like "$CC -c $CFLAGS $DRV_CFLAGS c_src/bitcask_nifs.c -o c_src/bitcask_nifs.o"
> and then you need to figure out yourself from the rest of the output what those
> environment variables expand to. I'd like to see the exact commands it's
> running. However, if this is a shortcoming of rebar, then I won't consider this
> as a blocker for the review.

Unfortunately, this is a shortcoming of rebar itself. I'll try to do something
with it in the future, but right now it should be considered as a "feature".

Just for the record - the only parameter which rebar passed to erlang bytecode
compile is +debug_info, which ensures that we'll add a small description to the
final bytecode, which greatly helps debugging.

This debugging section is simply discarded by Erlang VM while loading in the
standard operational mode (w/o debugger's invocation), so it doesn't affect
end-users. That's intended behavior and will be added as a "MUST" to final
Erlang Packaging Guidelines.

> - Another thing about the build. When building the C code, I'm fairly certain
> your package isn't passing the Fedora build options to cc. I suggest using the
> following line in %build, or something similar: "CFLAGS=$RPM_OPT_FLAGS rebar
> compile -v"

Good catch! Thanks. Here is a new package (updated to latest 1.1.5 version): 

http://peter.fedorapeople.org/erlang-bitcask.spec
http://peter.fedorapeople.org/erlang-bitcask-1.1.5-1.fc12.src.rpm

Koji scratchbuild for Rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2721264

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.