[Bug 664417] Review Request: spatialite-tools - A set of useful CLI tools for spatialite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664417

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |martin.gieseking at uos.de
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review?

--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de> 2011-01-15 04:38:27 EST ---
Hi Volker,

your package looks almost fine. Please update the spec file according to
Marco's comments. I also recommend to use the %{version} macro in Source0 to
simplify future updates, e.g.
http://www.gaia-gis.it/spatialite-%{version}-4/%{name}-%{version}.tar.gz

It would be nice to have a more detailed %description telling what kind of
tools the package provides and what they do.


$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
spatialite-tools.x86_64: W: no-manual-page-for-binary spatialite_osm_net
spatialite-tools.x86_64: W: no-manual-page-for-binary spatialite_osm_map
spatialite-tools.x86_64: W: no-manual-page-for-binary spatialite_osm_raw
spatialite-tools.x86_64: W: no-manual-page-for-binary spatialite
spatialite-tools.x86_64: W: no-manual-page-for-binary exif_loader
spatialite-tools.x86_64: W: no-manual-page-for-binary spatialite_tool
spatialite-tools.x86_64: W: no-manual-page-for-binary spatialite_gml
spatialite-tools.x86_64: W: no-manual-page-for-binary spatialite_network
spatialite-tools.x86_64: W: no-manual-page-for-binary shp_doctor
3 packages and 0 specfiles checked; 0 errors, 9 warnings.

The above warings are expected and can be ignored.

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    - GPLv3+ according to source headers

[X] MUST: The License field in the package spec file must match the actual
license.
    - GPLv3 => GPLv3+

[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
    - COPYING added in %doc

[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum spatialite-tools-2.4.0.tar.gz*
    e161e774a26e874d7d92d428ae2ad685  spatialite-tools-2.4.0.tar.gz
    e161e774a26e874d7d92d428ae2ad685  spatialite-tools-2.4.0.tar.gz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: library files that end in .so (without suffix) must go in a -devel
package.
[.] MUST: devel packages must require the base package
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[.] SHOULD: If the source package does not include license text(s) as a
separate file ...
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[X] SHOULD: your package should contain man pages for binaries/scripts.
    - it would be nice if upsetream could add manpages for the utilities

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.