[Bug 653435] Review Request: perl-Catalyst-Engine-PSGI - PSGI engine for Catalyst

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653435

--- Comment #5 from Petr Pisar <ppisar at redhat.com> 2011-01-17 03:02:48 EST ---
Spec file changes:
--- perl-Catalyst-Engine-PSGI.spec 2011-01-11 15:05:00.000000000 +0100
+++ perl-Catalyst-Engine-PSGI.spec.1 2011-01-14 16:04:43.000000000 +0100
@@ -55,7 +55,6 @@
 Requires:       perl(Catalyst::Action::RenderView)
 Requires:       perl(Catalyst::Runtime) >= 5.80007
 Requires:       perl(Filter::Util::Call)
-Requires:       perl(Plack::Loader)

 %{?perl_default_filter}
 %{?perl_default_subpackage_tests}
@@ -67,6 +66,10 @@
 %prep
 %setup -q -n Catalyst-Engine-PSGI-%{version}

+rm -rf inc/Test{More,Requires}.pm
+
+chmod 755 t/*
+
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}


> +rm -rf inc/Test{More,Requires}.pm
All tests pass. Ok.

> FIX: permissions in  perl-Catalyst-Engine-PSGI-tests.noarch
$ rpmlint perl-Catalyst-Engine-PSGI.spec
../SRPMS/perl-Catalyst-Engine-PSGI-0.12-1.fc15.src.rpm
../RPMS/noarch/perl-Catalyst-Engine-PSGI-*perl-Catalyst-Engine-PSGI-tests.noarch:
W: no-documentation
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_create.pl
0644L /usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_server.pl
0644L /usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/Makefile.PL 0644L
/usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello.psgi 0644L
/usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_test.pl
0644L /usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_cgi.pl 0644L
/usr/bin/env
perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script
/usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_fastcgi.pl
0644L /usr/bin/env
3 packages and 1 specfiles checked; 7 errors, 1 warnings.

FIX: The permissions has not been fixed. What about checking the package before
resubmitting it to the review? I guess this is due to %fix_shbang_line hooked
into %__spec_check_pre by /etc/rpm/macros.perl.


> FIX: Duplicate perl(Plack::Loader). Remove explicit one from spec file.
$ rpm -q --requires -p
../RPMS/noarch/perl-Catalyst-Engine-PSGI-0.12-1.fc15.noarch.rpm | sort | uniq
-c
      1 perl >= 0:5.008_001
      1 perl(App::Prove)  
      1 perl(Catalyst::Action::RenderView)  
      1 perl(Catalyst::Controller::Metal)  
      1 perl(Catalyst::Engine::PSGI)  
      1 perl(Catalyst::Runtime) >= 5.80007
      1 perl(Class::MOP)  
      1 perl(File::Spec)  
      1 perl(Filter::Util::Call)  
      1 perl(:MODULE_COMPAT_5.12.2)  
      1 perl(Moose)  
      1 perl(Plack::Loader)  
      1 perl(Scalar::Util)  
      1 perl(strict)  
      1 perl(Test::TCP)  
      1 perl(URI)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(VersionedDependencies) <= 3.0.3-1
$ rpm -q --requires -p
../RPMS/noarch/perl-Catalyst-Engine-PSGI-tests-0.12-1.fc15.noarch.rpm | sort |
uniq -c
      1 perl-Catalyst-Engine-PSGI = 0.12-1.fc15
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 /usr/bin/prove  
Binary requires Ok.

> I'm only not sure about doubled rpmlib:
This is a bug in rpmbuild. As you can see my rpmbuild from
rpm-build-4.8.1-6.fc15.x86_64 does not suffer from this.


Package build in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2725409). Ok.


Please correct all prefixed `FIX' issues and submit new spec file.
Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.