[Bug 670365] Review Request: perl-IO-Any - Read or write anything

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670365

Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de

--- Comment #1 from Ralf Corsepius <rc040203 at freenet.de> 2011-01-17 22:19:05 EST ---
Everything OK, except:

- The testsuite skips one of its tests:

+ ./Build test
t/01_IO-Any.t ........... ok
t/02_IO-Any_AnyEvent.t .. skipped: requires AnyEvent to run
t/03_DATA.t ............. ok
...

=> Missing "BuildRequires: perl(AnyEvent)"


- Duplicate "Requires:"
# rpm -q --requires -p perl-IO-Any-0.04-1.fc15.noarch.rpm 
...
perl(IO::AtomicFile)  
perl(IO::AtomicFile)  
perl(IO::File)  
perl(IO::String)  
perl(IO::String)  
... 

Please remove the explict "Requires: perl(IO::String)"
and "perl(IO::AtomicFile)"


CONSIDER (No blocker)

- You are not exercising the distritbution tests.
+ ./Build test
...
t/distribution.t ........ skipped: Test::Distribution not installed
t/fixme.t ............... skipped: requires Test::Fixme to run
t/pod-coverage.t ........ skipped: Test::Pod::Coverage 1.08 required for
testing POD coverage
t/pod-spell.t ........... skipped: Set the environment variable TEST_SPELLING
to enable this test.
t/pod.t ................. skipped: Test::Pod 1.22 required for testing POD

I'd recommend to add the missing BRs to have them exercised.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.