[Bug 670345] Review Request: cx_freeze - create executable from python scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670345

--- Comment #2 from Pierre-YvesChibon <pingou at pingoured.fr> 2011-01-18 05:29:54 EST ---
Quickly reading the spec file:

># sitelib for noarch packages, sitearch for others (remove the unneeded one)
>%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from >distutils.sysconfig import get_python_lib; print(get_python_lib())")}
>%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from >distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
Choose one of the other, but one should be removed

> Name:           cxfreeze 
Why did you choose this name ? I see cx_freeze more often on the website.
Please see http://fedoraproject.org/wiki/Packaging:NamingGuidelines

> License:        Python
hm, seeing this http://cx-freeze.sourceforge.net/LICENSE.txt I think it might
need to be reviewed to be sure the license is valid.

> Source0:        cx_Freeze-%{version}.tar.gz
This is not correct, please see
http://fedoraproject.org/wiki/Packaging/SourceURL

> Requires:       python >= 2.3 gcc
Are you sure the gcc should be explicitly required ?

> #add shebang
> for f in ${RPM_BUILD_ROOT}/%{python_sitearch}/cx_Freeze/initscripts/*
Why do you add shebang to file which will never be executed ?

> #not relevant
> rm -rf ${RPM_BUILD_ROOT}/%{python_sitearch}/cx_Freeze/samples
Why is it not relevant ? Couldn't it be provided as doc ?

There are several comments on your spec which you could clean.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.