[Bug 665995] Review Request: fmit - Free Music Instrument Tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665995

--- Comment #18 from Damian Wrobel <dwrobel at ertelnet.rybnik.pl> 2011-01-18 15:32:15 EST ---
(In reply to comment #16)
> Preserve timestamps:
> 
> install -Dpm 0644 %{SOURCE1} %{buildroot}%{_datadir}/pixmaps/%{name}.png
Fixed.

> 
> Patching to "default" seems mandatory, since I can reproduce a crash otherwise:
> 
> .) Start FMIT
> .) Configure --> Change "hw:0" to "default"
> .) Working fine
> .) Open configuration dialog again
> .) Crash
> 
The problem is that I've verified it on two different machines and the program
crashes for me using this scenario in both cases - without the patch and with
the patch as well.

If I changed the hw:0 to default also in the ConfigForm.ui file the program
even crashes every time during the startup.

On the other hand author can't reproduce the problem but has some suspicion
what can cause it and promised to fix it shortly.

As the program works in most typical scenarios and even if the user would faced
similar problem there is a simple workaround to recover from that situation by
simply deleting the ~/.qt/fmit009700rc file I would prefer either to not apply
that patch or to wait for a new version.

> NO MUST:
> =======
> 
> Remove "VERBOSE=1", since it is the default for %cmake.

Removed - assuming that the /etc/rpm/macros.cmake will keep it on - originally
it was taken from the cmake packaging guideline
(http://fedoraproject.org/wiki/Packaging/cmake).

> 
> Did you put "Music Instrument Tuner" instead of "Free Music Instrument Tuner"
> in the desktop file on purpose

Yes, I did.


Updated spec and SRPM:
Spec URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/fmit.spec
SRPM URL:
http://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/fmit-0.98.1-4.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.