[Bug 668098] Review Request: rubygem-tzinfo - Ruby library that uses the standard tz (Olson) database to provide daylight savings aware transformations between times in different time zones.

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 19 02:46:05 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668098

Mohammed Morsi <mmorsi at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mmorsi at redhat.com
         AssignedTo|nobody at fedoraproject.org    |mmorsi at redhat.com
               Flag|                            |fedora-review?

--- Comment #2 from Mohammed Morsi <mmorsi at redhat.com> 2011-01-18 21:46:04 EST ---
Looks mostly good. The only comment I would say is if you could include a
%check section and run 'rake test' in it. You will have to add a
BuildRequies(check)  for rubygem(rake)

rpmlint looks good, koji looks good

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list