[Bug 668243] Review Request: libqb - An IPC library for high performance servers.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668243

Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de

--- Comment #7 from Ralf Corsepius <rc040203 at freenet.de> 2011-01-19 01:25:43 EST ---
2 MUSTFIXES:

* From my build.log
...
./check_resources.sh: line 11: ps: command not found
...
=> missing BR: /bin/ps


* Package doesn't honor RPM_OPT_FLAGS.

The configure script plays nasty games with *FLAGS in a way they overwrite
Fedora's *FLAGS.

Excerpt from my build.log:
... gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I../include -O2 -g -pipe
-Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -O3 -ggdb3 -Wall ....

Note: ... "RPM_OPT_FLAGS"... -O3 -ggdb3.

The later overwrite flags from RPM_OPT_FLAGS.

One way to fix this is to sed out the stuff which is responsible for this from
configure.ac: e.g. by adding this before autogen.sh:

sed -i -e 's,OPT_CFLAGS="-O3",OPT_CFLAGS=,' \
 -e 's,GDB_FLAGS="-ggdb3",GDB_FLAGS=,' configure.ac


Should one of you be upstream, I'd seriously advise you to rework the
configure.ac and to start making "make dist" working to ship proerly packaged
tar-balls instead of .git snapshots.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.