[Bug 668243] Review Request: libqb - An IPC library for high performance servers.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668243

--- Comment #8 from Fabio Massimo Di Nitto <fdinitto at redhat.com> 2011-01-19 03:00:36 EST ---
(In reply to comment #7)
> 2 MUSTFIXES:
> 
> * From my build.log
> ...
> ./check_resources.sh: line 11: ps: command not found
> ...
> => missing BR: /bin/ps

Yes ACK, I think something has been fluxing in the chroot because in my
previous logs I didn´t have this issue at all. Now it is showing up. Probably
an update or something did change, anyway not worth investigating IMHO. The fix
is simple.

> 
> 
> * Package doesn't honor RPM_OPT_FLAGS.
> 
> The configure script plays nasty games with *FLAGS in a way they overwrite
> Fedora's *FLAGS.
> 
> Excerpt from my build.log:
> ... gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I../include -O2 -g -pipe
> -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
> --param=ssp-buffer-size=4 -m64 -mtune=generic -O3 -ggdb3 -Wall ....
> 
> Note: ... "RPM_OPT_FLAGS"... -O3 -ggdb3.
> 
> The later overwrite flags from RPM_OPT_FLAGS.
> 
> One way to fix this is to sed out the stuff which is responsible for this from
> configure.ac: e.g. by adding this before autogen.sh:
> 
> sed -i -e 's,OPT_CFLAGS="-O3",OPT_CFLAGS=,' \
>  -e 's,GDB_FLAGS="-ggdb3",GDB_FLAGS=,' configure.ac

I disagree with this approach as policy allow flags override.

http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

If upstream considers -O3 -ggdb3 better suitable for his code, they should
simply document that.

According to the build.log only "-O2 -g" are overridden.

> Should one of you be upstream, I'd seriously advise you to rework the
> configure.ac and to start making "make dist" working to ship proerly packaged
> tar-balls instead of .git snapshots.

make dist works just fine upstream, what problem are you experiencing exactly?
Random comments without some background information are not very useful.

I think what you miss is that the release script for libqb is capable of
handling both real release and snapshots to guarantee that the correct version
information are propagated across the board.

The srpm/rpm have been checked against a release tarball and they match. As
long as upstream releases and what is shipped in Fedora do match, I doubt it is
Fedora´s job to enforce any kind of release policy to upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.