[Bug 668243] Review Request: libqb - An IPC library for high performance servers.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668243

--- Comment #9 from Ralf Corsepius <rc040203 at freenet.de> 2011-01-19 06:21:23 EST ---
(In reply to comment #8)
> (In reply to comment #7)
> > 2 MUSTFIXES:

> > * Package doesn't honor RPM_OPT_FLAGS.
> > 
> > The configure script plays nasty games with *FLAGS in a way they overwrite
> > Fedora's *FLAGS.
> > 
> > Excerpt from my build.log:
> > ... gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I../include -O2 -g -pipe
> > -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
> > --param=ssp-buffer-size=4 -m64 -mtune=generic -O3 -ggdb3 -Wall ....
> > 
> > Note: ... "RPM_OPT_FLAGS"... -O3 -ggdb3.
> > 
> > The later overwrite flags from RPM_OPT_FLAGS.
> > 
> > One way to fix this is to sed out the stuff which is responsible for this from
> > configure.ac: e.g. by adding this before autogen.sh:
> > 
> > sed -i -e 's,OPT_CFLAGS="-O3",OPT_CFLAGS=,' \
> >  -e 's,GDB_FLAGS="-ggdb3",GDB_FLAGS=,' configure.ac
> 
> I disagree with this approach as policy allow flags override.
>
> http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
You are mis-interpreting this.

> If upstream considers -O3 -ggdb3 better suitable for his code, they should
> simply document that.
No. They simply must not override vital *FLAGS.

> According to the build.log only "-O2 -g" are overridden.
Correct  - These are vital and must not be overridden.

In case I was not clear enough: I will insist on this being fixed.

> > Should one of you be upstream, I'd seriously advise you to rework the
> > configure.ac and to start making "make dist" working to ship proerly packaged
> > tar-balls instead of .git snapshots.
> 
> make dist works just fine upstream, what problem are you experiencing exactly?
The tarball is improperly packaged - E.g. its lack all auto*generated files,
which forces the Fedora packager to explictly pull in the autotools.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.