[Bug 669311] Review Request: mupdf - A lightweight PDF viewer and toolkit written in portable C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669311

Mohamed El Morabity <pikachu.2014 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(pavel at zhukoff.net
                   |                            |)

--- Comment #19 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2011-01-19 10:41:30 EST ---
Thanks to all contributors who made comments on this review. The RPM looks
quite fine now.
Just a small comment: you should use %{_prefix} instead of /usr explicitely:
     make DESTDIR=%{buildroot} install prefix=%{buildroot}/%{_prefix}
LIBDIR=%{buildroot}%{_libdir}

Anyway the shared library issue is still there, and an upstream approval for
the corresponding patch is necessary; even if the patch does its job, it can
certainly be improved, moreover the choice of the ABI version belongs to the
mupad developers.
The approval of this package will depend on the upstream answer, whatever it
is.
Pavel, I invite you to report it to mupad devs as soon as possible, by
explaining our current policy concerning static libraries.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.