[Bug 668863] Review Request: dolphin-connector - Simple MySQL C API wrapper for C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668863

Pierre-YvesChibon <pingou at pingoured.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #15 from Pierre-YvesChibon <pingou at pingoured.fr> 2011-01-20 09:46:49 EST ---
Legend:
* OK
! Not OK
- Not Applicable

* rpmlint must be run on every package.
  3 packages and 0 specfiles checked; 0 errors, 0 warnings.
* The package follows the Package Naming Guidelines.
* The spec file name matches the base package %{name}, in the format
   %{name}.spec
* The package meets the Packaging Guidelines.
* The package is licensed with a Fedora approved license and meet the Licensing
  Guidelines.
    License BSD
* The License field in the package spec file matches the actual license.
* The source package includes the text of the license(s)and the package 
  includes it in %doc.
* The spec file is written in American English.
* The spec file for the package MUST be legible.
- The sources used to build the package must match the upstream source, as 
  provided in the spec URL.
    source from the src.rpm: c02c178324466f6054e5893d0cac251d
    Procedure described to generate the sources is clean
* The package successfully compiles and build into binary rpms on at least one 
  primary architecture.
    koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2733125
- If the package does not successfully compile, build or work on an
  architecture, then those architectures should be listed in the spec in 
  ExcludeArch.
* All build dependencies must be listed in BuildRequires, except for any that 
  are listed in the exceptions section of the Packaging Guidelines ; inclusion
  of those as BuildRequires is optional.
- The spec file MUST handle locales properly. This is done by using the 
  %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
* Every binary RPM package (or subpackage) which stores shared library 
  files(not just symlinks) in any of the dynamic linker's default paths, must 
  call ldconfig in %post and %postun.
* Packages do NOT bundle copies of system libraries.
- If the package is designed to be relocatable, the packager must state this 
  fact in the request for review, along with the rationalization for relocation 
  of that specific package. Without this, use of Prefix: /usr is considered a 
  blocker.
* A package must own all directories that it creates. If it does not create a 
  directory that it uses, then it should require a package which does create 
  that directory.
* Package does not list a file more than once in the spec file's %files 
  listings. 
* Permissions on files must be set properly. Executables should be set with 
  executable permissions, for example. Every %files section must include a 
  %defattr(...) line.
* Each package consistently uses macros.
* The package contains code, or permissable content.
- Large documentation files must go in a -doc subpackage.
* Files included something as %doc, do not affect the runtime of the 
  application.
* Header files are in a -devel package.
- Static libraries must be in a -static package.
* Package contains library files with a suffix (e.g. libfoo.so.1.1), library 
  files that end in .so (without suffix) are in a -devel package.
* Devel packages requires the base package using a fully versioned dependency: 
  Requires: %{name} = %{version}-%{release}.
* Packages do NOT contain any .la libtool archives.
- Packages containing GUI applications includes a %{name}.desktop file, and 
  that file must be properly installed with desktop-file-install in the 
  %install section.
* Packages do not own files or directories already owned by other packages.
* All filenames in rpm packages must be valid UTF-8.


So this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.