[Bug 664982] Review Request: perl-Parallel-Prefork - Simple prefork server framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664982

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |iarnell at gmail.com
         AssignedTo|nobody at fedoraproject.org    |iarnell at gmail.com
               Flag|                            |fedora-review+

--- Comment #2 from Iain Arnell <iarnell at gmail.com> 2011-01-21 02:34:33 EST ---
+ source files match upstream.  
    d4b9347c414e7f0d30708e14e05ee3a6  Parallel-Prefork-0.11.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
    GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock (locally, rawhide)
+ package installs properly.
+ rpmlint has no meaningful complaints:
    perl-Parallel-Prefork.noarch: W: spelling-error %description -l en_US
ForkManager -> Fork Manager, Fork-manager, Micromanager
    perl-Parallel-Prefork.src: W: spelling-error %description -l en_US
ForkManager -> Fork Manager, Fork-manager, Micromanager
    2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ final provides and requires are sane:
    perl(Parallel::Prefork) = 0.11
    perl-Parallel-Prefork = 0.11-1.fc15
    perl(Parallel::Prefork::SpareWorkers)  
    perl(Parallel::Prefork::SpareWorkers::Scoreboard)  

=
    perl >= 0:5.008_001
    perl(base)  
    perl(Class::Accessor::Lite)  
    perl(constant)  
    perl(Exporter)  
    perl(Fcntl)  
    perl(File::Temp)  
    perl(List::MoreUtils)  
    perl(List::Util)  
    perl(:MODULE_COMPAT_5.12.2)  
    perl(Parallel::Prefork)  
    perl(Parallel::Prefork::SpareWorkers)  
    perl(POSIX)  
    perl(Proc::Wait3)  
    perl(Scope::Guard)  
    perl(strict)  
    perl(Time::HiRes)  
    perl(warnings)  

+ %check is present and all tests pass (review request exists for
perl-Parallel-Scoreboard to complete test suite)
    t/01-base.t .......... ok
    t/02-reconfigure.t ... ok
    t/03-spareworkers.t .. ok
    t/04-interval.t ...... skipped: Test requires module 'Parallel::Scoreboard'
but it's not found
    All tests successful.
    Files=4, Tests=16, 11 wallclock secs ( 0.03 usr  0.01 sys +  0.24 cusr 
0.12 csys =  0.40 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

A nice clean package. APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.