[Bug 671030] Review Request: dogtag-pki-theme - Certificate System, Dogtag PKI Theme Components

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 21 09:23:45 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=671030

--- Comment #4 from Parag AN(पराग) <panemade at gmail.com> 2011-01-21 04:23:43 EST ---
(In reply to comment #3)
> (In reply to comment #2)
> > 1) Package failed to build as its missing BR: java
> > 2) some packages owns /usr/share/pki and some not. But i think its already
> > owned by pki-setup now.
> > 3) Add following in %install
> > chmod 755 %{buildroot}%{_datadir}/pki/tps-ui/cgi-bin/sow/cfg.pl
> > 
> > and remove from %files of dogtag-pki-tps-theme
> > %attr(00755,root,root) %{_datadir}/pki/tps-ui/cgi-bin/sow/cfg.pl
> > 
> > This will make sure, duplicate files warning will not come in build.log
> 
> Updated SPEC and SRPM specified below address comments 1) and 3):
> 
> Spec URL:
> http://mharmsen.fedorapeople.org/dogtag-pki-theme.spec
> 
> SRPM URL:
> http://mharmsen.fedorapeople.org/dogtag-pki-theme-9.0.0-2.fc12.src.rpm
> 
> In reference to comment 2), Dogtag consists of numerous subsystems which can be
> installed independently of each other.  As a consequence of this flexibility,
> several components may need to have ownership of the '/usr/share/pki'
> directory, as they may be the only component on a given system.  Where
> possible, we have tried to isolate this to the lowest common dependency (e. g.
> - 'pki-setup' is required by all six top-level Dogtag subsystems).  However, in
> the case of "theme" packages such as "dogtag-pki-theme", no package requires
> this at build time, and "theme" packages may be installed without requiring
> other Dogtag packages such as "pki-setup" (actually, packages such as 'pki-ca'
> require "pki-ca-theme" which is something provided by "theme" packages such as
> "dogtag-pki-ca-theme").

In that case, I think other subpackages  dogtag-pki-tks-theme,
dogtag-pki-ocsp-theme, dogtag-pki-kra-theme, dogtag-pki-ca-theme should also
own '/usr/share/pki'

Good to add comment somewhere in spec about directory ownership.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list