[Bug 664812] Review Request: perl-HTML-Quoted - Extract structure of quoted HTML mail message

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664812

--- Comment #3 from Petr Pisar <ppisar at redhat.com> 2011-01-21 06:32:11 EST ---
Spec file changes:

--- perl-HTML-Quoted.spec 2010-12-21 19:12:04.000000000 +0100
+++ perl-HTML-Quoted.spec.1 2011-01-20 17:25:03.000000000 +0100
@@ -1,5 +1,5 @@
 Name:           perl-HTML-Quoted
-Version:        0.02
+Version:        0.03
 Release:        1%{?dist}
 Summary:        Extract structure of quoted HTML mail message
 License:        GPL+ or Artistic
@@ -8,14 +8,14 @@
 Source0:       
http://www.cpan.org/authors/id/R/RU/RUZ/HTML-Quoted-%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:      noarch
-BuildRequires:  perl >= 1:5.8.0
 BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(HTML::Parser) >= 3.0
 BuildRequires:  perl(Test::More)
+BuildRequires:  perl(Data::Dumper)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

 %description
-Extract structure of quoted HTML mail message
+Extract structure of quoted HTML mail message.

 %prep
 %setup -q -n HTML-Quoted-%{version}
@@ -47,5 +47,8 @@
 %{_mandir}/man3/*

 %changelog
+* Thu Jan 20 2011 Ralf Corsépius <corsepiu at fedoraproject.org> - 0.03-1
+- Upstream update.
+
 * Tue Dec 21 2010 Ralf Corsépius <corsepiu at fedoraproject.org> - 0.02-1
 - Initial Fedora package.


No Changes in dependencies of sources.

Changes in dependencies of tests:
+use strict;
+use warnings;
+use Test::More tests => 1;
+use HTML::Quoted;
+use Data::Dumper;

No significant changes in META.yml.


Source file original. Ok.

> TODO: Add full stop on the end of Description. You can use %{summary} macro
> to refer the text.
-Extract structure of quoted HTML mail message
+Extract structure of quoted HTML mail message.
Ok.

> FIX: BuildRequire perl(Data::Dumper) (t/lines.t) as it can dual-live in the
> future (http://search.cpan.org/~smueller/Data-Dumper/)
+BuildRequires:  perl(Data::Dumper)
Ok.

Build-time dependecies Ok.

All tests pass. Ok.

$ rpmlint perl-HTML-Quoted.spec ../SRPMS/perl-HTML-Quoted-0.03-1.fc14.src.rpm
../RPMS/noarch/perl-HTML-Quoted-0.03-1.fc14.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-HTML-Quoted-0.03-1.fc14.noarch.rpm 
drwxr-xr-x    2 root    root                        0 led 21 10:23
/usr/share/doc/perl-HTML-Quoted-0.03
-rw-r--r--    1 root    root                      277 led  9 05:55
/usr/share/doc/perl-HTML-Quoted-0.03/Changes
-rw-r--r--    1 root    root                     1787 led  9 06:59
/usr/share/doc/perl-HTML-Quoted-0.03/README
-rw-r--r--    1 root    root                     2576 led 21 10:23
/usr/share/man/man3/HTML::Quoted.3pm.gz
drwxr-xr-x    2 root    root                        0 led 21 10:23
/usr/share/perl5/HTML
-rw-r--r--    1 root    root                     8176 led  9 06:59
/usr/share/perl5/HTML/Quoted.pm
File permissions and layout Ok.

> FIX: Require perl(HTML::Parser) >= 3.0 (lib/HTML/Quoted.pm:40, META.yml:22)
$ rpm -q --requires -p ../RPMS/noarch/perl-HTML-Quoted-0.03-1.fc14.noarch.rpm |
sort | uniq -c 
      1 perl(base)  
      1 perl(:MODULE_COMPAT_5.12.2)  
      1 perl(strict)  
      1 perl(warnings)  
      1 perl >= 0:5.008
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rpmlib(VersionedDependencies) <= 3.0.3-1
FIX: Require perl(HTML::Parser) >= 3.0 (lib/HTML/Quoted.pm:98, META.yml:22)

$ rpm -q --provides -p ../RPMS/noarch/perl-HTML-Quoted-0.03-1.fc14.noarch.rpm |
sort | uniq -c 
      1 perl(HTML::Quoted::Parser)  
      1 perl(HTML::Quoted) = 0.03
      1 perl-HTML-Quoted = 0.03-1.fc14
Binary provides Ok.

$ resolvedeps-f15 ../RPMS/noarch/perl-HTML-Quoted-0.03-1.fc14.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2734607). Ok.


Please correct all `FIX' prefixed issues and submit new spec file.
Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.