[Bug 668153] Review Request: openresolv - Management framework for resolv.conf

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668153

--- Comment #6 from Jiri Popelka <jpopelka at redhat.com> 2011-01-21 10:57:45 EST ---
Spec URL: http://jpopelka.fedorapeople.org/openresolv.spec
SRPM URL: http://jpopelka.fedorapeople.org/openresolv-3.4.1-2.fc14.src.rpm


(In reply to comment #5)
> openresolv.noarch: W: manual-page-warning /usr/share/man/man8/resolvconf.8.gz
> 3375: bad character definition
> openresolv.noarch: W: manual-page-warning /usr/share/man/man8/resolvconf.8.gz
> 3379: warning: macro `\}' not defined
> openresolv.noarch: W: manual-page-warning
> /usr/share/man/man5/resolvconf.conf.5.gz 3375: bad character definition
> openresolv.noarch: W: manual-page-warning
> /usr/share/man/man5/resolvconf.conf.5.gz 3379: warning: macro `\}' not defined
> 
> ^^^ I failed to find what caused this message, but I'm suspection that it is
> triggered by configuration snippets, containing curly brackets. I'm not sure
> whether it's a issue or not.
Nor I am able to find out what could be wrong, but the man pages look good.

> openresolv.src: W: strange-permission openresolv-3.4.1.tar.bz2 0755L
> openresolv.src: W: strange-permission openresolv-service-status-quiet.patch
> 0755L
> openresolv.src: W: strange-permission openresolv.spec 0755L
> 
> ^^^ This should be fixed as well (easyfix).
Have no idea how they got there, hope it's ok now.

> - The package MUST own all directories that it creates. Please, mark explicitly
> %{_libexecdir}/resolvconf as %dir in the %files section.
Fixed.

> +/- Permissions on files are set properly. Just drop executable permissions
> from original sources (spec-file, patch and tarball).
See above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.