[Bug 654879] Review Request: since - stateful tail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=654879

--- Comment #9 from Martin Gieseking <martin.gieseking at uos.de> 2011-01-21 11:28:01 EST ---
Here are some comments on your latest spec:

- I recommend not to adapt the Makefile but assign the proper CFLAGS in the
make
  statement instead:
  make CFLAGS='%{optflags} -DVERSION=\"%{version}\"' %{?_smp_mflags}
  This is much safer since sed might silently fail if the pattern doesn't 
  match.

- use macro %{_prefix} in the %install section:
  make install prefix=$RPM_BUILD_ROOT/%{_prefix} INSTALL='install -Dp'

- clear the exec perms of the manpage (in %install), e.g.:
  chmod 644 $RPM_BUILD_ROOT/%{_mandir}/man1/since.1

- in %files, please use either the %{name} macro or "since". Don't mix them:

  %{_bindir}/%{name}
  %{_mandir}/man1/%{name}.1*

  or

  %{_bindir}/since
  %{_mandir}/man1/since.1*

- replace %clean with %%clean in the %changelog to make rpmlint happy


$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
since.src: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless,
Stately
since.src:35: W: macro-in-%changelog %clean
since.x86_64: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless,
Stately
since.x86_64: W: spurious-executable-perm /usr/share/man/man1/since.1.gz
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.