[Bug 642773] Review Request: iguanaIR - Driver for Iguanaworks USB IR transceiver
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jan 21 16:52:44 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
Jason Tibbitts <tibbs at math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |tibbs at math.uh.edu
Flag| |fedora-review?
--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu> 2011-01-21 11:52:43 EST ---
Builds fine; rpmlint has a few complaints:
iguanaIR.x86_64: W: non-standard-uid /var/run/iguanaIR iguanair
iguanaIR.x86_64: W: non-standard-gid /var/run/iguanaIR iguanair
iguanaIR.x86_64: W: non-standard-uid /lib/udev/devices/iguanaIR iguanair
iguanaIR.x86_64: W: non-standard-gid /lib/udev/devices/iguanaIR iguanair
Obviously these are OK because the package adds a user, though there's also a
group which isn't added by this package.
iguanaIR.x86_64: W: no-manual-page-for-binary igdaemon
iguanaIR.x86_64: W: no-manual-page-for-binary igclient
iguanaIR-devel.x86_64: W: no-documentation
iguanaIR-python.x86_64: W: no-documentation
iguanaIR-reflasher.noarch: W: no-documentation
iguanaIR-reflasher.noarch: W: no-manual-page-for-binary iguanaIR-reflasher
Manpages would be nice, but if upstream doesn't provide documentation then it's
not as if you should write it.
iguanaIR.x86_64: W: incoherent-init-script-name iguanaIR
('iguanair', 'iguanaird')
Just rpmlint failing to understand the name of the initscript.
iguanaIR-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/iguanaIR-1.0.1/iguanaIR_wrap.c
Kind of weird for a .c file to be executable, but it just gets copied from the
builddir by rpm magic. If you like you can fix it with a quick chmod in %prep.
iguanaIR-python.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/_iguanaIR.so _iguanaIR.so()(64bit)
I'd suggest filtering this but I don't think you can use the dependency
filtering stuff because this package has other compiled libraries and
executables.
Unfortunately I can't seem to fetch the upstream source. Following the
Source0: URL, I get redirected to
http://iguanaworks.net/products.psp/releases/iguanaIR-1.0.1.tar.bz2 which
redirects me again to /products.psp. I think the proper thing is:
Source0: http://iguanaworks.net/downloads/%{name}-%{version}%{?snap}.tar.bz2
You can probably get rid of the snap stuff now that there's a release, unless
you intend to pull further post-release snapshots.
I note that /etc/default is an odd place for settings used by an initscript.
Generally we'd put them in /etc/sysconfig.
I'm somewhat confused about the license. docs/license says everything is
either LGPLv2 or GPLv2, though it also has a really troubling bit about them
automatically claiming copyright over anything you "submit" to them.
However, you'd have to go through the files in the binary packages and figure
out what's GPL and what's LGPL. I'm not sure it all collapses down to GPL.
Shouldn't you be creating the iguanair group as well? And is there any
specific reason not to use the recommended scriptlets for setting that up?
There is no reason to call ldconfig for the -devel package; it only installs a
symlink.
I note that udev is only pulled in very incidentally, I think because the
scriptlets depend on initscripts. It might be useful to make that dependency
more explicit.
* source files match upstream. sha256sum:
1ba324667671892b2a36aee0089d0afafd266f8b255b073b113eb5ab71f38fcc
iguanaIR-1.0.1.tar.bz2
(using updated Source0: URL)
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
? not sure about the license field
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
X final provides and requires:
iguanaIR-1.0.1-1.fc15.x86_64.rpm
config(iguanaIR) = 1.0.1-1.fc15
libiguanaIR.so.0()(64bit)
libiguanaIR.so.0(IGUANAIR_0)(64bit)
libusb.so()(64bit)
libusbpre1.so()(64bit)
iguanaIR = 1.0.1-1.fc15
iguanaIR(x86-64) = 1.0.1-1.fc15
=
/bin/sh
/sbin/chkconfig
/sbin/ldconfig
/sbin/service
config(iguanaIR) = 1.0.1-1.fc15
libiguanaIR.so.0()(64bit)
libiguanaIR.so.0(IGUANAIR_0)(64bit)
libpopt.so.0()(64bit)
libpopt.so.0(LIBPOPT_0)(64bit)
libusb-0.1.so.4()(64bit)
libusb-1.0.so.0()(64bit)
lirc
iguanaIR-devel-1.0.1-1.fc15.x86_64.rpm
iguanaIR-devel = 1.0.1-1.fc15
iguanaIR-devel(x86-64) = 1.0.1-1.fc15
=
X /sbin/ldconfig
iguanaIR = 1.0.1-1.fc15
libiguanaIR.so.0()(64bit)
iguanaIR-python-1.0.1-1.fc15.x86_64.rpm
? _iguanaIR.so()(64bit)
iguanaIR-python = 1.0.1-1.fc15
iguanaIR-python(x86-64) = 1.0.1-1.fc15
=
iguanaIR = 1.0.1-1.fc15
libiguanaIR.so.0()(64bit)
libiguanaIR.so.0(IGUANAIR_0)(64bit)
libpython2.7.so.1.0()(64bit)
python >= 2.4
python(abi) = 2.7
iguanaIR-reflasher-1.0.1-1.fc15.noarch.rpm
iguanaIR-reflasher = 1.0.1-1.fc15
=
/usr/bin/python
iguanaIR-python = 1.0.1
* no bundled libraries (that I can see).
* shared libraries are installed:
ldconfig is called properly (on the main package, at least).
unversioned .so link is in the -devel package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* scriptlets on main package are OK (ldconfig).
X scriptlets on devel package are unnecessary.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no static libraries.
* no libtool .la files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list