[Bug 666954] Review Request: cherrytree - Hierarchical note taking application

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 21 19:56:38 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=666954

--- Comment #21 from Robin Lee <robinlee.sysu at gmail.com> 2011-01-21 14:56:37 EST ---
(In reply to comment #20)
> (In reply to comment #15)
> I also removed the useless egg. It's not even a SHOULD because the python files
> of this package cannot be used by something else. I added the python(abi)
> requirement manually.
OK.

TODO: With respect to deb/control and modules/core.py, this package depends on
7za, so please add /usr/bin/7za to requirement. I said this earlier.

TODO: %{_datadir}/application-registry/%{name}.applications and
%{_datadir}/mime-info/%{name}.* are redundant and should be excluded. Just
%{_datadir}/mime/packages/%{name}.xml and
%{_datadir}/applications/%{name}.desktop are useful with the current xdg
mimetype mechanism.

Refer to:
http://standards.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html

TODO: Typos: 'unclude', 'manually ad'.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list