[Bug 670457] Review Request: toilet - colorful ASCII art generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670457

--- Comment #4 from Pierre-YvesChibon <pingou at pingoured.fr> 2011-01-22 15:34:18 EST ---
(In reply to comment #1) 
>  * Under %files you are listing all files under /usr/share/man/man1/ (this
> could overlap with Build Dependencies and should be more specific).
> 
>      %doc %{_mandir}/man1/toilet.1.gz

This is actually quite wrong. The %file section can make use of * and actually
uses it a lot (just see
http://fedoraproject.org/wiki/Packaging/Python#Byte_compiling for example)
There is no way file listed under %file can overlap with Build Dependencies
(these are not present in the buildroot where your files are). What you have to
make sure in the review though is that there are files having the same name and
place in the filesystem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.