[Bug 671883] Review Request: v4l-utils - Utilities for video4linux and DVB devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=671883

--- Comment #2 from Hans de Goede <hdegoede at redhat.com> 2011-01-23 09:51:20 EST ---
(In reply to comment #1)
> Not a formal review, just some feedback from trying to build this package in
> rawhide-mock:
> 

Thanks for the feedback!

> 
> 1. I am facing several warnings of this kind:
> 
> make[2]: Entering directory
> `/builddir/build/BUILD/v4l-utils-0.8.2-test/utils/libv4l2util'
> make[2]: warning: jobserver unavailable: using -j1.  Add `+' to parent make
> rule.
> 
> ... no idea about the cause. Wild guess: Broken makefiles.

Fixed by this upstream commit:
http://git.linuxtv.org/v4l-utils.git?a=commitdiff;h=ad1bfbbea5960243fdaf93a6d3386ff0c65b6337

> 
> 2. A file does not compile:
> cc -Wp,-MMD,"keytable.d",-MQ,"keytable.o",-MP -c -I../../include
> -I../../lib/include -D_GNU_SOURCE -O2 -g -pipe -Wall 
> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
> --param=ssp-buffer-size=4 -m64 -mtune=generic -o keytable.o keytable.c
> keytable.c:87:66: error: expected ',' or ';' before 'V4L_UTILS_VERSION'
> 

Ah, this happens when specifying CFLAGS explicitly, fixed by this upstream
commit:
http://git.linuxtv.org/v4l-utils.git?a=commitdiff;h=d0b2dcf42230a337943164cd0bc2ebd1c4725543

> 3. After the error from 2. above occurs, make doesn't abort the build process,
> but continues.

Oh, good one! Bad error propagation in a for $SUBDIRS loop, fixed:
http://git.linuxtv.org/v4l-utils.git?a=commitdiff;h=f51ac9f8b4dd0265575fd41ebaa36327309e4ae7

There still is one other issue which needs to be taken care of upstream. Then
I'll do a real 0.8.2 release upstream and drop a link to an updated srpm here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.