[Bug 668090] Review Request: rubygem-railties - Rails internals: application bootup, plugins, generators, and rake tasks.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668090

--- Comment #2 from Minnikhanov <minnikhanov at gmail.com> 2011-01-23 15:46:43 EST ---
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-2.fc14.spec
SRPM URL:
http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-2.fc14.src.rpm 

koji scratch build: FAIL
http://koji.fedoraproject.org/koji/taskinfo?taskID=2738446 
root.log
>>>
DEBUG backend.py:745:  /usr/bin/yum-builddep --installroot
/var/lib/mock/dist-f15-build-964373-145195/root/ 
'/var/lib/mock/dist-f15-build-964373-145195/root///builddir/build/SRPMS/rubygem-railties-3.0.3-2.fc15.src.rpm'
DEBUG util.py:281:  Executing command: /usr/bin/yum-builddep --installroot
/var/lib/mock/dist-f15-build-964373-145195/root/ 
'/var/lib/mock/dist-f15-build-964373-145195/root///builddir/build/SRPMS/rubygem-railties-3.0.3-2.fc15.src.rpm'
DEBUG util.py:247:  Getting requirements for rubygem-railties-3.0.3-2.fc15.src
DEBUG util.py:247:   --> rubygems-1.3.7-2.fc14.noarch
DEBUG util.py:247:   --> ruby-libs-1.8.7.330-2.fc15.x86_64
DEBUG util.py:247:  Error: No Package found for rubygem(date)
DEBUG util.py:320:  Child returncode was: 1
<<<

(In reply to comment #1)
> 
> rubygem-railties-doc.noarch: E: script-without-shebang
> /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/guides/assets/stylesheets/syntaxhighlighter/shThemeMDUltra.css
> 
> This stylesheet seems to be mistakingly marked as executable in the upstream
> source, can prolly chmod it to remove the executable permission
>
+ Fixed  in %prep.

> rubygem-railties.noarch: W: hidden-file-or-dir
> /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/lib/rails/generators/rails/app/templates/test/fixtures/.empty_directory
> rubygem-railties.noarch: E: zero-length
> /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/lib/rails/generators/rails/app/templates/test/fixtures/.empty_directory
> 
> There are a bunch of these errors for various .empty_directory files in the
> railties gem, these need to be included in the project correct?
> 
I delete these files in %prep. (??? - my opinion).
I guess its need for generator as some mark. I look at source. 
No empty folder here lib/rails/generators/rails/app/templates/*
This need addition info.

> * rm -rf %{buildroot} at the beginning of %install isn't needed and should be
> removed
+ Fixed.

> * Feel free to tar up the upstream test suite for the 3.0.3 railties release
> and run it in a %check section in the rpm
> 
+ Make %check section.
Rakefile:
>>>
require 'rake'
require 'rake/testtask'
require 'rake/gempackagetask'

require 'date'
require 'rbconfig'
<<<
Make 
BuildRequires: rubygem(date)
BuildRequires: rubygem(rbconfig)

rubygem-date didn't pack.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.