[Bug 668090] Review Request: rubygem-railties - Rails internals: application bootup, plugins, generators, and rake tasks.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668090

--- Comment #4 from Minnikhanov <minnikhanov at gmail.com> 2011-01-24 14:57:35 EST ---
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-3.fc14.spec
SRPM URL:
http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-3.fc14.src.rpm 

koji scratch build: FAIL
http://koji.fedoraproject.org/koji/taskinfo?taskID=2740113 
build.log
>>>
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.N6GfTX
+ umask 022
+ cd /builddir/build/BUILD
+ cd rubygem-railties-3.0.3
+ unset DISPLAY
+ pushd
/builddir/build/BUILDROOT/rubygem-railties-3.0.3-3.fc15.noarch/usr/lib/ruby/gems/1.8/gems/railties-3.0.3
~/build/BUILDROOT/rubygem-railties-3.0.3-3.fc15.noarch/usr/lib/ruby/gems/1.8/gems/railties-3.0.3
~/build/BUILD/rubygem-railties-3.0.3
+ rake test
rake aborted!
(eval):1:in `read': No such file or directory -
/builddir/build/BUILDROOT/rubygem-railties-3.0.3-3.fc15.noarch/usr/lib/ruby/gems/1.8/gems/RAILS_VERSION
/builddir/build/BUILDROOT/rubygem-railties-3.0.3-3.fc15.noarch/usr/lib/ruby/gems/1.8/gems/railties-3.0.3/Rakefile:60
(See full trace by running task with --trace)
(in
/builddir/build/BUILDROOT/rubygem-railties-3.0.3-3.fc15.noarch/usr/lib/ruby/gems/1.8/gems/railties-3.0.3)
error: Bad exit status from /var/tmp/rpm-tmp.N6GfTX (%check)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.N6GfTX (%check)
Child returncode was: 1
<<<

Will you advise about 'BuildRequires:'

I guess this is not full list:
BuildRequires: rubygems
BuildRequires: ruby(abi) = %{rubyabi}
BuildRequires: rubygem(rake)

(In reply to comment #3)
> (In reply to comment #2)

> 
> date isn't a rubygem. Its part of the ruby standard library. Same with
> rbconfig. See
> 
> /usr/lib/ruby/1.8/date.rb
> /usr/lib/ruby/1.8/i386-linux/rbconfig.rb
> 
+ Fixed.


> Thanks alot. The find command doing so isn't just right though. Running it, I
> get 
> 
> "find: missing argument to `-exec'"
> 
> To fix this append "{} \;" to the end of the find command like so:
> 
> find ./%{geminstdir} -name *.css -type f -perm /a+x -exec chmod -v 644 {} \;
> 
+ Fixed.

> > 
> > > rubygem-railties.noarch: W: hidden-file-or-dir
> > > /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/lib/rails/generators/rails/app/templates/test/fixtures/.empty_directory
> > > rubygem-railties.noarch: E: zero-length
> > > /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/lib/rails/generators/rails/app/templates/test/fixtures/.empty_directory

Is any way to lean these files? I'll prefer don't delete these file.
I guess all 'empty folders' marked to avoid some variables have value = 'nil'
by algorithm. We can have unstable side effects, IMHO.
I'll test before at %check with deleted files.

> > > 
> > > There are a bunch of these errors for various .empty_directory files in the
> > > railties gem, these need to be included in the project correct?
> > > 
> > I delete these files in %prep. (??? - my opinion).
> > I guess its need for generator as some mark. I look at source. 
> > No empty folder here lib/rails/generators/rails/app/templates/*
> > This need addition info.
> > 
> 
> They do seem to be in the upstream source, see for example
> 
> https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/generator/templates/templates/.empty_directory
> 
> It might not be a bad idea to lean on the safe side and leave them included. Or
> at the very least, ensure the test suite works w/ those files removed.
>

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.