[Bug 670457] Review Request: toilet - colorful ASCII art generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670457

--- Comment #8 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2011-01-25 13:42:55 EST ---
The reviews you've gotten look good for this package.  A few clarifications:

1) man pages are automatically marked as %doc by rpm.  That's why you don't
mark them as %doc explicitly. (I'm not sure if your original spec file just did
%doc toilet.1 or if it did %doc %{_mandir}/man*/toilet.*  I assume the latter
which is otherwise correct)

2) I notice that you don't set the CFLAGS explictly when building the program. 
This works fine for this package since it's being picked up from the
Environment variables that rpmbuild sets.  However, some Makefiles don't do
that and you have to either set that when you call %configure or when you call
make build.  You can look at the output from building the program to see if you
need to do that or not.  Just something to be aware of since Makefiles differ
so much from package to package.

I see you need a sponsor to get into the packager group.  Have you done any
reviews of other packages that I could look at?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.