[Bug 658420] Review Request: zorba - General purpose XQuery processor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=658420

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jussi.lehtola at iki.fi
         AssignedTo|nobody at fedoraproject.org    |jussi.lehtola at iki.fi
               Flag|                            |fedora-review?

--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-01-25 14:41:19 EST ---
rpmlint output:

zorba.src: W: spelling-error %description -l en_US embeddable -> embedding,
embedded, shreddable
zorba.src: W: spelling-error %description -l en_US pluggable -> plug gable,
plug-gable, plugged
zorba.src:217: E: files-attr-not-set
zorba.src:218: E: files-attr-not-set
zorba.src:219: E: files-attr-not-set
zorba.src: E: specfile-error sh: php-config: command not found
zorba.src: E: specfile-error error: Macro %php_extdir has empty body
zorba.x86_64: W: spelling-error %description -l en_US embeddable -> embedding,
embedded, shreddable
zorba.x86_64: W: spelling-error %description -l en_US pluggable -> plug gable,
plug-gable, plugged
zorba.x86_64: W: shared-lib-calls-exit /usr/lib64/libzorba_simplestore.so.1.4.0
exit at GLIBC_2.2.5
zorba.x86_64: W: no-manual-page-for-binary zorba
zorba-devel.x86_64: W: no-documentation
zorba-java.x86_64: W: no-documentation
zorba-php.x86_64: W: no-documentation
zorba-python.x86_64: W: no-documentation
zorba-ruby.x86_64: W: no-documentation
9 packages and 0 specfiles checked; 5 errors, 11 warnings.

- The -php package is missing %defattr, please add it.
- The specfile-errors are caused by me not having php-devel installed.

- You can drop BR: php-devel, since it requires php. 
- ruby-devel only requires ruby-libs, so if you need ruby then you do need to
BR it explicitly.

***

Please move the rpm requires filtering part to the top of the specfile, whete
the other definitions are.

***

The Java guidelines at http://fedoraproject.org/wiki/Packaging/Java state:

"Installation directory
All JAR files MUST go into %{_javadir} or a Java-version specific directory
%{_javadir}-* as appropriate[1]. If the number of provided JAR files exceeds
two, you MUST place them into a sub-directory named %{name}."

Is there any reason you're not complying to this in the -java package?

Also, please preserve the timestamp on build/swig/java/zorba.jar in %install.

***

You should be able to disable RPATH altogether within CMake. See
http://www.cmake.org/Wiki/CMake_RPATH_handling

***

Fix the line endings in %prep. And preserve the timestamp while doing it. For
instance with

find . -name *.css > cssfiles
for file in `cat cssfiles`; do
 sed "s|\r||g" $file > $file.new && \
 touch -r $file $file.new && \
 mv $file.new $file
done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.