[Bug 662259] Review Request: git-annex - Manage files with git, without checking their contents in

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662259

Andrew McNabb <amcnabb at mcnabbs.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amcnabb at mcnabbs.org

Bug 662259 depends on bug 634037, which changed state.

Bug 634037 Summary: Review Request: ghc-MissingH - Large utility library
https://bugzilla.redhat.com/show_bug.cgi?id=634037

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA
             Status|ON_QA                       |CLOSED
         Resolution|                            |ERRATA

--- Comment #1 from Andrew McNabb <amcnabb at mcnabbs.org> 2011-01-26 13:40:46 EST ---
Here are a few issues from the rpmlint output:

> git-annex.src: W: invalid-url Source0: git-annex-0.11.tar.bz2

The Source0 needs to be a full URL, not just a filename.  I can't seem to find
a tarball on the git-annex website.  Can you work with upstream to get them to
publish a tarball for each new version?

> git-annex.x86_64: W: spurious-executable-perm /usr/share/man/man1/git-annex.1.gz

This should be fixed.

> git-annex-debuginfo.x86_64: E: debuginfo-without-sources

Have you tried to fix this error?

A few other issues:

1) The %description seems a little long.  Most packages seem to have one or
maybe two brief paragraphs.

2) This is a dumb preference, but I would slightly change the summary to
"Manage files with git, without checking in their contents".

3) It looks like there have been a few version updates since the last time the
spec file was updated.

4) Have you sent the patches to the Makefile upstream?  By the way, it looks
like the documentation is correctly installed by the Makefile in a newer
version of git-annex.

5) Two of the dependencies are unavailable on Fedora 14.  I can't really do
anything more on this review until the ghc-pcre-light package is in.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.