[Bug 672807] Review Request: perl-CPAN-Meta-YAML - Read and write a subset of YAML for CPAN Meta files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672807

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2011-01-26 23:27:25 EST ---
+ source files match upstream.  
    62d0f9726a2b91971b2f3f4ac770de5d  CPAN-Meta-YAML-0.003.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
    Though I would lose the 2nd paragraph - it's not really relevant for a
    package description

+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
    GPL+ or Artistic

+ license is open source-compatible.
+ license text included
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2744924

+ package installs properly.
+ rpmlint has no complaints:
    perl-CPAN-Meta-YAML.noarch: W: spelling-error %description -l en_US
metadata -> meta data, meta-data, metatarsus
    perl-CPAN-Meta-YAML.noarch: W: spelling-error %description -l en_US
bugtracker -> bug tracker, bug-tracker, nutcracker
    perl-CPAN-Meta-YAML.src: W: spelling-error %description -l en_US metadata
-> meta data, meta-data, metatarsus
    perl-CPAN-Meta-YAML.src: W: spelling-error %description -l en_US bugtracker
-> bug tracker, bug-tracker, nutcracker
    2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ final provides and requires are sane:
    perl(CPAN::Meta::YAML) = 0.003
    perl-CPAN-Meta-YAML = 0.003-2.fc15
=
    perl(:MODULE_COMPAT_5.12.3)  
    perl(strict)  

+ %check is present and all tests pass.
    + make test 'TEST_FILES=t/*.t xt/*/*.t'
    PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'blib/lib', 'blib/arch')" t/*.t xt/*/*.t
    t/01_compile.t ........... ok
    t/02_basic.t ............. ok
    t/03_regression.t ........ ok
    t/04_scalar.t ............ ok
    t/05_export.t ............ ok
    t/11_meta_yml.t .......... ok
    t/12_plagger.t ........... ok
    t/13_perl_smith.t ........ ok
    t/14_yaml_org.t .......... ok
    t/15_multibyte.t ......... ok
    t/16_nullrefs.t .......... ok
    t/17_toolbar.t ........... ok
    t/18_tap.t ............... ok
    t/19_errors.t ............ ok
    t/20_subclass.t .......... ok
    t/21_bom.t ............... ok
    t/22_comments.t .......... ok
    xt/release/distmeta.t .... ok
    xt/release/pod-syntax.t .. ok
    All tests successful.
    Files=19, Tests=3448,  2 wallclock secs ( 0.36 usr  0.05 sys +  1.79 cusr 
0.23 csys =  2.43 CPU)
    Result: PASS
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


My only minor gripe is that the 2nd paragraph of %description isn't really
relevant for us.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.