[Bug 672975] Review Request: perl-Pango - Perl interface to the pango library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672975

--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu> 2011-01-26 23:53:31 EST ---
Builds fine; rpmlint says:
  perl-Pango.x86_64: W: private-shared-object-provides
   /usr/lib64/perl5/vendor_perl/auto/Pango/Pango.so Pango.so()(64bit)
  perl-Pango.x86_64: W: private-shared-object-provides
   /usr/lib64/perl5/vendor_perl/auto/Pango/Pango.so Pango.so()(64bit)
These should probably be filtered.  %{?perl_default_filter} should take care of
it.

  perl-Pango.x86_64: W: devel-file-in-non-devel-package
   /usr/lib64/perl5/vendor_perl/Pango/Install/pango-perl-autogen.h
  perl-Pango.x86_64: W: devel-file-in-non-devel-package
   /usr/lib64/perl5/vendor_perl/Pango/Install/pango-perl.h
  perl-Pango.x86_64: W: devel-file-in-non-devel-package
   /usr/lib64/perl5/vendor_perl/Pango/Install/pango-perl-versions.h
These are OK.

Note that rpm finds a dependency on perl(Glib) itself, so your manual one
results in a duplicate.  Not really sure why it doesn't find any dependency on
perl(Cairo).

Anyway, the duplicate isn't really a problem as long as it's needed to force an
update, though it does reveal an issue:  F13 only has perl-Glib 1.201.  (It's
never actually been built for F13.)  You're the maintainer so I guess updating
it shouldn't be an issue.

* source files match upstream.  sha256sum:
  af524d0b6749fb5762f1152dbe02ed547a2a7308a1f667fce96cfbb2ca7d25c6
   Pango-1.221.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
X rpmlint has valid complaints.
* final provides and requires are sane:
   Pango.so()(64bit)  
   perl(Pango) = 1.221
   perl(Pango::Install::Files)  
   perl-Pango = 1.221-1.fc15
   perl-Pango(x86-64) = 1.221-1.fc15
  =
   libcairo.so.2()(64bit)  
   libfreetype.so.6()(64bit)  
   libglib-2.0.so.0()(64bit)  
   libgmodule-2.0.so.0()(64bit)  
   libgobject-2.0.so.0()(64bit)  
   libgthread-2.0.so.0()(64bit)  
   libpango-1.0.so.0()(64bit)  
   libpangocairo-1.0.so.0()(64bit)  
   perl >= 0:5.008
   perl(:MODULE_COMPAT_5.12.3)  
   perl(Cairo) >= 1.000
   perl(DynaLoader)  
   perl(Exporter)  
   perl(Glib)  
   perl(Glib) >= 1.220
   perl(strict)  
   perl(warnings)  

* no bundled libraries.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.