[Bug 629324] Review Request: python-zc-buildout - System for managing development buildouts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=629324

--- Comment #3 from Robin Lee <robinlee.sysu at gmail.com> 2011-01-27 02:33:25 EST ---
Spec URL: http://cheeselee.fedorapeople.org/python-zc-buildout.spec
SRPM URL:
http://cheeselee.fedorapeople.org/python-zc-buildout-1.5.2-1.fc14.src.rpm

Changes:
- 1.5.2
- Don't use sed command in Source0 URI
- Remove the doctest text files.
- Clean up obsolete lines

$ rpmlint ./python-zc-buildout-1.5.2-1.fc14.noarch.rpm 
python-zc-buildout.noarch: W: spelling-error Summary(en_US) buildouts -> build
outs, build-outs, buildups
python-zc-buildout.noarch: W: no-manual-page-for-binary buildout
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


(In reply to comment #2)
> Are you sure this shouldn't be named python-zc.buildout?  (I'm not sure myself;
> the egg is named with a ot but I'm not sure how you import the package.)
'When a module has a dot in its name, the usual rule about changing "." to "-"
applies. '
quoted from the just updated naming guideline:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29

> 
> Source0: http://pypi.python.org/packages/source/%(echo %{modname} | sed -r
> 's|^(.).*|\1|')/%{modname}/%{modname}-%{version}.tar.gz
> 
> Is that really better than just dispensing with the macros?  At least, just
> using 'z' seems significantly shorter and it's closer to being readable as
> well.
OK.

> 
> Also, there's no point in keeping anything for F12's sake as F12 is no longer
> supported.
OK. The review request was submitted when F12 was still supported.

> 
> What are the txt files doing down with the python source files?  They look like
> documentation.
They are doctest text files. I will exclude them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.