[Bug 672801] Review Request: perl-Perl-OSType - Map Perl operating system names to generic types

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672801

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Petr Pisar <ppisar at redhat.com> 2011-01-27 04:30:47 EST ---
Spec file changes:

--- perl-Perl-OSType.spec       2011-01-26 16:19:02.353995456 +0100
+++ perl-Perl-OSType.spec.1     2011-01-26 19:34:59.000000000 +0100
@@ -1,12 +1,12 @@
 # We don't really need ExtUtils::MakeMaker > 6.31
-%global old_eumm %(%{__perl} -MExtUtils::MakeMaker -e 'printf "%d\\n",
$ExtUtils::MakeMaker::VERSION < 6.31 ? 1 : 0;' 2>/dev/null || echo 0)
+%global old_eumm %(perl -MExtUtils::MakeMaker -e 'printf "%d\\n",
$ExtUtils::MakeMaker::VERSION < 6.31 ? 1 : 0;' 2>/dev/null || echo 0)

 # Test suite needs patching if we have Test::More < 0.88
-%global old_test_more %(%{__perl} -MTest::More -e 'printf "%d\\n",
$Test::More::VERSION < 0.88 ? 1 : 0;' 2>/dev/null || echo 0)
+%global old_test_more %(perl -MTest::More -e 'printf "%d\\n",
$Test::More::VERSION < 0.88 ? 1 : 0;' 2>/dev/null || echo 0)

 Name:          perl-Perl-OSType
 Version:       1.002
-Release:       2%{?dist}
+Release:       3%{?dist}
 Summary:       Map Perl operating system names to generic types
 License:       GPL+ or Artistic
 Group:         Development/Libraries
@@ -16,7 +16,10 @@
 Patch1:                Perl-OSType-1.002-old-Test::More.patch
 BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:     noarch
+BuildRequires: perl(constant)
+BuildRequires: perl(Exporter)
 BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(File::Temp)
 # Pod::Coverage::TrustPod not yet in EPEL-4
 %if "%{?rhel}" != "4"
 BuildRequires: perl(Pod::Coverage::TrustPod)
@@ -75,6 +78,10 @@
 %{_mandir}/man3/Perl::OSType.3pm*

 %changelog
+* Wed Jan 26 2011 Paul Howarth <paul at city-fan.org> - 1.002-3
+- BR: perl(constant), perl(Exporter), perl(File::Temp) in case they are
+  dual-lived at some point (#672801)
+
 * Wed Jan 26 2011 Paul Howarth <paul at city-fan.org> - 1.002-2
 - Sanitize for Fedora submission


> FIX: BuildRequire perl(File::Temp) (t/00-compile.t:16) as it can dual-live in
> the future (http://search.cpan.org/~tjenness/File-Temp/).
+BuildRequires: perl(File::Temp)
Ok.

> FIX: BuildRequire perl(constant) (t/OSType.t:6) as it can dual-live in the
> future (http://search.cpan.org/~saper/constant/).
+BuildRequires: perl(constant)
Ok.

> FIX: BuildRequire perl(Exporter) (lib/Perl/OSType.pm:17) as it can dual-live
> in the future (http://search.cpan.org/~ferreira/Exporter/).
+BuildRequires: perl(Exporter)
Ok.


$ rpmlint perl-Perl-OSType.spec ../SRPMS/perl-Perl-OSType-1.002-3.fc15.src.rpm
../RPMS/noarch/perl-Perl-OSType-1.002-3.fc15.noarch.rpm 
perl-Perl-OSType.src: W: spelling-error %description -l en_US linux -> Linux
perl-Perl-OSType.src: W: spelling-error %description -l en_US freebsd ->
freebased, freebase, freebie
perl-Perl-OSType.noarch: W: spelling-error %description -l en_US linux -> Linux
perl-Perl-OSType.noarch: W: spelling-error %description -l en_US freebsd ->
freebased, freebase, freebie
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

rpmlint Ok.

Package builds in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2745094). Ok.


Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.